mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint events
Date: Tue, 5 Jan 2016 11:38:20 +0100	[thread overview]
Message-ID: <20160105103820.GA5133@krava.brq.redhat.com> (raw)
In-Reply-To: <1450708013-7805-6-git-send-email-namhyung@kernel.org>

On Mon, Dec 21, 2015 at 11:26:48PM +0900, Namhyung Kim wrote:

SNIP

> +	free(str);
> +	return ret;
> +}
> +
>  static int __sort_dimension__add(struct sort_dimension *sd)
>  {
>  	if (sd->taken)
> @@ -1667,6 +1887,9 @@ static int sort_dimension__add(const char *tok,

sort_dimension__add's evlist arg could loose the '__maybe_unused' now

thanks,
jirka

>  		return 0;
>  	}
>  
> +	if (!add_dynamic_entry(evlist, tok))
> +		return 0;
> +
>  	return -ESRCH;
>  }
>  
> -- 
> 2.6.4
> 

  reply	other threads:[~2016-01-05 10:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-21 14:26 [PATCHSET 00/10] perf tools: Support dynamic sort keys for tracepoints (v3) Namhyung Kim
2015-12-21 14:26 ` [PATCH 01/10] perf hist: Pass struct sample to __hists__add_entry() Namhyung Kim
2015-12-21 14:26 ` [PATCH 02/10] perf hist: Save raw_data/size for tracepoint events Namhyung Kim
2015-12-21 14:26 ` [PATCH 03/10] tools lib traceevent: Factor out and export print_event_field[s] Namhyung Kim
2015-12-21 14:26 ` [PATCH 04/10] perf tools: Pass evlist to setup_sorting() Namhyung Kim
2015-12-21 14:26 ` [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint events Namhyung Kim
2016-01-05 10:38   ` Jiri Olsa [this message]
2015-12-21 14:26 ` [PATCH 06/10] perf tools: Try to show pretty printed output for dynamic sort keys Namhyung Kim
2015-12-21 14:26 ` [PATCH 07/10] perf tools: Add 'trace' sort key Namhyung Kim
2015-12-22  7:22   ` Jiri Olsa
2015-12-22 14:47     ` Namhyung Kim
2015-12-21 14:26 ` [PATCH 08/10] perf tools: Add --raw-trace option Namhyung Kim
2015-12-21 14:26 ` [PATCH 09/10] perf tools: Make 'trace' sort key default for tracepoint events Namhyung Kim
2015-12-22  7:29   ` Jiri Olsa
2015-12-22 14:49     ` Namhyung Kim
2015-12-21 14:26 ` [PATCH 10/10] perf tools: Support shortcuts for events in dynamic sort keys Namhyung Kim
2016-01-04 21:17 ` [PATCHSET 00/10] perf tools: Support dynamic sort keys for tracepoints (v3) Arnaldo Carvalho de Melo
2016-01-05  0:22   ` Namhyung Kim
  -- strict thread matches above, loose matches on Subject: below --
2015-12-15 15:35 [PATCHSET 00/10] perf tools: Support dynamic sort keys for tracepoints (v2) Namhyung Kim
2015-12-15 15:35 ` [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint events Namhyung Kim
2015-12-20 13:51   ` Jiri Olsa
2015-12-20 14:02     ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160105103820.GA5133@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome