From: David Miller <davem@davemloft.net>
To: jarod@redhat.com
Cc: linux-kernel@vger.kernel.org, eugene.shatokhin@rosalab.ru,
prudy1@o2.pl, jcliburn@gmail.com, chris.snook@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] ethernet/atheros/alx: sanitize buffer sizing and padding
Date: Wed, 06 Jan 2016 15:05:39 -0500 (EST) [thread overview]
Message-ID: <20160106.150539.179421707935774818.davem@davemloft.net> (raw)
In-Reply-To: <1452090997-27683-1-git-send-email-jarod@redhat.com>
From: Jarod Wilson <jarod@redhat.com>
Date: Wed, 6 Jan 2016 09:36:37 -0500
> This is based on the work done by Przemek Rudy in bug 70761 at
> bugzilla.kernel.org, but with some work done to disentagle and clarify
> things a bit.
>
> Similar to Przemek's work and other drivers, we're adding a padding of 16
> here, but we're also disentangling mtu size calculations from max buffer
> size calculations a bit, and adding ETH_HLEN to the value written into
> ALX_MTU. Hopefully, with a bit more consistency and clarity, things behave
> better here. Sadly, I can only test in my alx-driven E2200, which worked
> just fine before this patch.
>
> In comment #58 of bug 70761, Eugene A. Shatokhin reports that this patch
> does help considerably for a ROSA Linux user of his with an AR8162 network
> adapter when patched into a 4.1.x-based kernel, with several days of
> normal operation where wired network previously wasn't usable without
> setting MTU to 9000 as a work-around.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=70761
> CC: "Eugene A. Shatokhin" <eugene.shatokhin@rosalab.ru>
> CC: Przemek Rudy <prudy1@o2.pl>
> CC: Jay Cliburn <jcliburn@gmail.com>
> CC: Chris Snook <chris.snook@gmail.com>
> CC: netdev@vger.kernel.org
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> ---
> v2: remove superfluous parens around raw_mtu, pointed out by davem
Looks great, applied, thanks Jarod.
prev parent reply other threads:[~2016-01-06 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 23:12 [PATCH " Jarod Wilson
2016-01-06 6:23 ` David Miller
2016-01-06 14:36 ` [PATCH v2 " Jarod Wilson
2016-01-06 20:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106.150539.179421707935774818.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris.snook@gmail.com \
--cc=eugene.shatokhin@rosalab.ru \
--cc=jarod@redhat.com \
--cc=jcliburn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prudy1@o2.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®