mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Florian Fainelli <florian@openwrt.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] net: ti: cpmac: Fix build error due to missed API change
Date: Sat, 9 Jan 2016 22:23:47 +0100	[thread overview]
Message-ID: <20160109212347.GB6877@lunn.ch> (raw)
In-Reply-To: <1452374379-18644-1-git-send-email-linux@roeck-us.net>

On Sat, Jan 09, 2016 at 01:19:39PM -0800, Guenter Roeck wrote:
> Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to
> a bus") introduces an API to access mii_bus structures, but missed to
> update the TI cpamc driver. This results in the following error message.
> 
> drivers/net/ethernet/ti/cpmac.c: In function 'cpmac_probe':
> drivers/net/ethernet/ti/cpmac.c:1119:18: error:
> 	'struct mii_bus' has no member named 'phy_map'
> 
> Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus")
> Cc: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Acked-by: Andrew Lunn <andrew@lunn.ch>

Thanks
	Andrew

> ---
>  drivers/net/ethernet/ti/cpmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
> index 0b483301767d..7eef45e6d70a 100644
> --- a/drivers/net/ethernet/ti/cpmac.c
> +++ b/drivers/net/ethernet/ti/cpmac.c
> @@ -1116,7 +1116,7 @@ static int cpmac_probe(struct platform_device *pdev)
>  		for (phy_id = 0; phy_id < PHY_MAX_ADDR; phy_id++) {
>  			if (!(pdata->phy_mask & (1 << phy_id)))
>  				continue;
> -			if (!cpmac_mii->phy_map[phy_id])
> +			if (!mdiobus_get_phy(cpmac_mii, phy_id))
>  				continue;
>  			strncpy(mdio_bus_id, cpmac_mii->id, MII_BUS_ID_SIZE);
>  			break;
> -- 
> 2.1.4
> 

      reply	other threads:[~2016-01-09 21:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-09 21:19 Guenter Roeck
2016-01-09 21:23 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160109212347.GB6877@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=florian@openwrt.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome