mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: linux@roeck-us.net, =adi-buildroot-devel@lists.sourceforge.net,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next v2] net: bfin_mac: Fix build error due to missed API change
Date: Sun, 10 Jan 2016 23:30:43 -0500 (EST)	[thread overview]
Message-ID: <20160110.233043.1721701935879616026.davem@davemloft.net> (raw)
In-Reply-To: <20160110154532.GB22229@lunn.ch>

From: Andrew Lunn <andrew@lunn.ch>
Date: Sun, 10 Jan 2016 16:45:32 +0100

> On Sun, Jan 10, 2016 at 07:08:04AM -0800, Guenter Roeck wrote:
>> Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to
>> a bus") introduces an API to access mii_bus structures, but missed to
>> update the bfin_mac driver. This results in the following error message
>> 
>> drivers/net/ethernet/adi/bfin_mac.c: In function 'mii_probe':
>> drivers/net/ethernet/adi/bfin_mac.c:401:52: error:
>> 	'struct mii_bus' has no member named 'phy_map'
>> 
>> Use phy_find_first() instead of open-coding it.
>> 
>> Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus")
>> Cc: Andrew Lunn <andrew@lunn.ch>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Acked-by: Andrew Lunn <andrew@lunn.ch>
> 
> Hi Dave
> 
> Although Sadip Mukerjee's patch [PATCH 1/2] phy: fix blackfin build failure
> is correct, this one is better. Please take this one in preference. 
> We do still however need Sadip's [2/2] bfin_mac: fix error path

Sorry, I applied Sadip's patch already.

I'll need to get something relative if you really want this
variant in my tree.

Thanks.

      reply	other threads:[~2016-01-11  4:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-10 15:08 Guenter Roeck
2016-01-10 15:45 ` Andrew Lunn
2016-01-11  4:30   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160110.233043.1721701935879616026.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc==adi-buildroot-devel@lists.sourceforge.net \
    --cc=andrew@lunn.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®