From: Mark Brown <broonie@kernel.org>
To: Chen Feng <puck.chen@hisilicon.com>
Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com, yudongbin@hisilicon.com,
saberlily.xia@hisilicon.com, suzhuangluan@hisilicon.com,
kong.kongxinwei@hisilicon.com, xuyiping@hisilicon.com,
z.liuxinliang@hisilicon.com, puck.chenfeng@gmail.com,
weidong2@hisilicon.com, w.f@huawei.com, qijiwen@hisilicon.com,
peter.panshilin@hisilicon.com, dan.zhao@hisilicon.com,
linuxarm@huawei.com, liguozhu@hisilicon.com
Subject: Re: [PATCH v5 4/5] regulator: add regulator driver of hi655x pmic
Date: Mon, 11 Jan 2016 18:24:44 +0000 [thread overview]
Message-ID: <20160111182444.GR6588@sirena.org.uk> (raw)
In-Reply-To: <1452514817-118311-5-git-send-email-puck.chen@hisilicon.com>
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On Mon, Jan 11, 2016 at 08:20:16PM +0800, Chen Feng wrote:
> +config REGULATOR_HI655X
> + tristate "Hisilicon HI655X PMIC regulators support"
> + depends on ARCH_HISI || (COMPILE_TEST && ARM64)
Why does this depend on ARM64? If it's needed it probably indicates a
problem...
> + np = of_get_child_by_name(dev->parent->of_node, "regulators");
> + if (!np)
> + return -ENODEV;
> +
> + ret = of_regulator_match(dev, np,
> + hi655x_regulator_match,
> + ARRAY_SIZE(hi655x_regulator_match));
Like I said on the previous version:
| Don't open code this, use the standard support with of_match and
| regulators_node.
The code is now using of_match but still open coding regulators_node.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-11 18:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 12:20 [PATCH v5 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core Chen Feng
2016-01-11 12:20 ` [PATCH v5 1/5] doc: bindings: Add document for mfd hi665x PMIC Chen Feng
2016-01-25 12:53 ` Lee Jones
2016-01-26 6:26 ` chenfeng
2016-01-11 12:20 ` [PATCH v5 2/5] doc: bindings: Document for hi655x regulator driver Chen Feng
2016-01-11 18:17 ` Mark Brown
2016-01-12 2:07 ` chenfeng
2016-01-11 12:20 ` [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver Chen Feng
2016-01-25 14:22 ` Lee Jones
2016-01-26 6:32 ` chenfeng
2016-01-28 9:48 ` chenfeng
2016-01-28 11:30 ` Lee Jones
2016-01-11 12:20 ` [PATCH v5 4/5] regulator: add regulator driver of hi655x pmic Chen Feng
2016-01-11 18:24 ` Mark Brown [this message]
2016-01-12 2:18 ` chenfeng
2016-01-15 18:07 ` Mark Brown
2016-01-18 8:26 ` chenfeng
2016-01-11 12:20 ` [PATCH v5 5/5] hisilicon/dts: Add hi655x pmic dts node Chen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111182444.GR6588@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dan.zhao@hisilicon.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=peter.panshilin@hisilicon.com \
--cc=puck.chen@hisilicon.com \
--cc=puck.chenfeng@gmail.com \
--cc=qijiwen@hisilicon.com \
--cc=saberlily.xia@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=w.f@huawei.com \
--cc=weidong2@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=yudongbin@hisilicon.com \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®