* [PATCH resend] component: demote bind messages to debug level
@ 2016-01-12 12:00 Lucas Stach
2016-01-12 12:05 ` Russell King - ARM Linux
0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2016-01-12 12:00 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Russell King, linux-kernel, patchwork-lst
The component bind messages are mostly redundant as most drivers print
a more specific message themselves when binding has succeeded. As they
don't add much value, but can get noisy with a lot of components in the
system demote them to debug level.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/base/component.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/component.c b/drivers/base/component.c
index f748430bb654..867ace2404f1 100644
--- a/drivers/base/component.c
+++ b/drivers/base/component.c
@@ -417,8 +417,8 @@ static int component_bind(struct component *component, struct master *master,
devres_close_group(component->dev, NULL);
devres_remove_group(master->dev, NULL);
- dev_info(master->dev, "bound %s (ops %ps)\n",
- dev_name(component->dev), component->ops);
+ dev_dbg(master->dev, "bound %s (ops %ps)\n",
+ dev_name(component->dev), component->ops);
} else {
devres_release_group(component->dev, NULL);
devres_release_group(master->dev, NULL);
--
2.6.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH resend] component: demote bind messages to debug level
2016-01-12 12:00 [PATCH resend] component: demote bind messages to debug level Lucas Stach
@ 2016-01-12 12:05 ` Russell King - ARM Linux
0 siblings, 0 replies; 2+ messages in thread
From: Russell King - ARM Linux @ 2016-01-12 12:05 UTC (permalink / raw)
To: Lucas Stach; +Cc: Greg Kroah-Hartman, linux-kernel, patchwork-lst
On Tue, Jan 12, 2016 at 01:00:59PM +0100, Lucas Stach wrote:
> The component bind messages are mostly redundant as most drivers print
> a more specific message themselves when binding has succeeded. As they
> don't add much value, but can get noisy with a lot of components in the
> system demote them to debug level.
These provide useful information when things don't work out right. For
example, imx-drm's crtc components are completely silent, like Dove's
armada-drm components as well. etnaviv is actually silent from the
component bind functions: it's only afterwards when we initialise the
GPUs that were found that we print anything there.
So, I don't deem them to be redundant.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-12 12:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-12 12:00 [PATCH resend] component: demote bind messages to debug level Lucas Stach
2016-01-12 12:05 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®