From: Joshua Clayton <stillcompiling@gmail.com>
To: Lucas Stach <dev@lynxeye.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04
Date: Tue, 12 Jan 2016 12:40:23 -0800 [thread overview]
Message-ID: <20160112124023.1ef170d5@jclayton-pc> (raw)
In-Reply-To: <1452624330.2628.3.camel@lynxeye.de>
Hi Lucas,
Thanks for the review.
On Tue, 12 Jan 2016 19:45:30 +0100
Lucas Stach <dev@lynxeye.de> wrote:
> > drivers/gpu/drm/panel/panel-simple.c | 26
> > ++++++++++++++++++++++++++
>
> Missing documentation for the DT binding.
>
Thanks, will add.
...
> > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> > +};
> > +
> This hunk isn't added at the correct place. Please keep the
> alphabetical sorting.
OK. Makes sense. I'll reorder these.
>
> > static const struct display_timing hannstar_hsd070pww1_timing = {
> > .pixelclock = { 64300000, 71100000, 82000000 },
> > .hactive = { 1280, 1280, 1280 },
> > @@ -1146,6 +1169,9 @@ static const struct of_device_id
> > platform_of_match[] = {
> > .compatible = "hannstar,hsd070pww1",
> > .data = &hannstar_hsd070pww1,
> > }, {
> > + .compatible = "sharp,lq101k1ly04",
> > + .data = &sharp_lq101k1ly04,
> > + }, {
>
> Wrong insertion place again.
OK. Will reorder alphabetically also.
Joshua
prev parent reply other threads:[~2016-01-12 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 16:05 Joshua Clayton
2016-01-12 17:41 ` Joshua Clayton
2016-01-12 18:45 ` Lucas Stach
2016-01-12 20:40 ` Joshua Clayton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112124023.1ef170d5@jclayton-pc \
--to=stillcompiling@gmail.com \
--cc=airlied@linux.ie \
--cc=dev@lynxeye.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®