* [RESEND][PATCH] Staging: unisys: fix potential format string leak
@ 2016-01-12 17:59 Kees Cook
0 siblings, 0 replies; only message in thread
From: Kees Cook @ 2016-01-12 17:59 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Benjamin Romer, David Kershner, Erik Arfvidson, Shraddha Barke,
sparmaintainer, devel, linux-kernel
Since "name" is always used directly, force "%s" for the kthread
format string to avoid any potential format string leaks.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c
index c119f20dfd44..89712144f804 100644
--- a/drivers/staging/unisys/visorhba/visorhba_main.c
+++ b/drivers/staging/unisys/visorhba/visorhba_main.c
@@ -167,7 +167,7 @@ static int visor_thread_start(struct visor_thread_info *thrinfo,
{
/* used to stop the thread */
init_completion(&thrinfo->has_stopped);
- thrinfo->task = kthread_run(threadfn, thrcontext, name);
+ thrinfo->task = kthread_run(threadfn, thrcontext, "%s", name);
if (IS_ERR(thrinfo->task)) {
thrinfo->id = 0;
return PTR_ERR(thrinfo->task);
--
2.6.3
--
Kees Cook
Chrome OS & Brillo Security
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-01-12 18:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-12 17:59 [RESEND][PATCH] Staging: unisys: fix potential format string leak Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®