From: Mark Brown <broonie@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stefan Agner <stefan@agner.ch>,
festevam@gmail.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: Lockdep warning when using REGCACHE_RBTREE
Date: Fri, 15 Jan 2016 11:49:46 +0000 [thread overview]
Message-ID: <20160115114946.GV6588@sirena.org.uk> (raw)
In-Reply-To: <20160115094541.GH3421@worktop>
[-- Attachment #1: Type: text/plain, Size: 542 bytes --]
On Fri, Jan 15, 2016 at 10:45:41AM +0100, Peter Zijlstra wrote:
> So _regmap_write() does: map->lock(map->lock_arg)
> Which isn't very enlightening, since that can be a mutex or a spinlock,
> the above strongly suggests spinlock though.
> Looking at __regmap_init(), this seems to depend on:
> (bus && bus->fast_io) || config->fast_io
> now, afaict, regmap_mmio is used in this case, which has .fast_io =
> true.
> So yeah, fail.
Indeed, that'd do it. It hadn't occurred to me that someone would be
using MMIO with an rbtree cache.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-01-15 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 22:30 Stefan Agner
2016-01-15 0:01 ` Mark Brown
2016-01-15 1:14 ` Stefan Agner
2016-01-15 16:28 ` Mark Brown
2016-01-15 19:08 ` Stefan Agner
2016-01-15 9:45 ` Peter Zijlstra
2016-01-15 11:49 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115114946.GV6588@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome