From: Al Viro <viro@ZenIV.linux.org.uk>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] amdkfd: Copy from the proper user command pointer
Date: Fri, 15 Jan 2016 19:09:39 +0000 [thread overview]
Message-ID: <20160115190939.GE17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1452882404-24627-1-git-send-email-bp@alien8.de>
On Fri, Jan 15, 2016 at 07:26:44PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> 8f1d57c17248 ("amdkfd: don't open-code memdup_user()") mistakenly uses
> an uninitialized local pointer, gcc complains:
>
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c: In function ‘kfd_ioctl_dbg_address_watch’:
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:562:12: warning: ‘args_buff’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> args_buff = memdup_user(args_buff,
> ^
>
> Fix it.
Mea culpa... Applied, and I wonder how the hell I'd missed that..
prev parent reply other threads:[~2016-01-15 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 18:26 Borislav Petkov
2016-01-15 19:09 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115190939.GE17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome