* Re: virtio pull for 4.5 (was Re: [PULL] virtio: barrier rework+fixes) [not found] ` <20160118152028-mutt-send-email-mst@redhat.com> @ 2016-01-19 1:01 ` Linus Torvalds 2016-01-21 10:23 ` Michael S. Tsirkin 0 siblings, 1 reply; 2+ messages in thread From: Linus Torvalds @ 2016-01-19 1:01 UTC (permalink / raw) To: Michael S. Tsirkin Cc: KVM list, virtualization, Network Development, Linux Kernel Mailing List, Andrew Morton, Alexander Duyck, Rafael Aquini, Arnd Bergmann, Benjamin Herrenschmidt, Bjorn Andersson, Boqun Feng, tony.luck On Mon, Jan 18, 2016 at 5:21 AM, Michael S. Tsirkin <mst@redhat.com> wrote: > Hi Linus, > Just making sure nothing's wrong with this pull request. > If there's an issue, pls let me know! It was just pulled because I wasn't 100% sure I wanted the extra indirection. Oh well, pulled now. One question: - the arch/sh/ part of the pacth looks dubious. Why does it do that #define smp_store_mb(var, value) __smp_store_mb(var, value) despite the commit log saying it's done by asm-generic? I haven't pushed out yet, my allmodconfig sanity-check build is still going.. Linus ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: virtio pull for 4.5 (was Re: [PULL] virtio: barrier rework+fixes) 2016-01-19 1:01 ` virtio pull for 4.5 (was Re: [PULL] virtio: barrier rework+fixes) Linus Torvalds @ 2016-01-21 10:23 ` Michael S. Tsirkin 0 siblings, 0 replies; 2+ messages in thread From: Michael S. Tsirkin @ 2016-01-21 10:23 UTC (permalink / raw) To: Linus Torvalds Cc: KVM list, virtualization, Network Development, Linux Kernel Mailing List, Andrew Morton, Alexander Duyck, Rafael Aquini, Arnd Bergmann, Benjamin Herrenschmidt, Bjorn Andersson, Boqun Feng, tony.luck On Mon, Jan 18, 2016 at 05:01:26PM -0800, Linus Torvalds wrote: > On Mon, Jan 18, 2016 at 5:21 AM, Michael S. Tsirkin <mst@redhat.com> wrote: > > Hi Linus, > > Just making sure nothing's wrong with this pull request. > > If there's an issue, pls let me know! > > It was just pulled because I wasn't 100% sure I wanted the extra > indirection. Oh well, pulled now. > > One question: > > - the arch/sh/ part of the pacth looks dubious. Why does it do that > > #define smp_store_mb(var, value) __smp_store_mb(var, value) > > despite the commit log saying it's done by asm-generic? > > I haven't pushed out yet, my allmodconfig sanity-check build is still going.. > > Linus Oh that's because that's what the existing code did, so the original version of the patch left the bug in place. I wanted to include the fix and I wrote this in the commit message, but I forgot to include it in the code :( Thankfully this just means that the commit log is wrong, the code is just unchanged from 4.4, and I'll include a fix in my tree shortly. -- MST ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-21 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20160113182855-mutt-send-email-mst@redhat.com>
[not found] ` <20160118152028-mutt-send-email-mst@redhat.com>
2016-01-19 1:01 ` virtio pull for 4.5 (was Re: [PULL] virtio: barrier rework+fixes) Linus Torvalds
2016-01-21 10:23 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®