From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, eranian@google.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/9] perf, tools, stat: Abstract stat metrics printing
Date: Fri, 22 Jan 2016 10:41:32 +0100 [thread overview]
Message-ID: <20160122094132.GA27246@krava.brq.redhat.com> (raw)
In-Reply-To: <1453256812-24006-2-git-send-email-andi@firstfloor.org>
On Tue, Jan 19, 2016 at 06:26:44PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Abstract the printing of shadow metrics. Instead of every
> metric calling fprintf directly and taking care of indentation,
> use two call backs: one to print metrics and another to
> start a new line.
>
> This will allow adding metrics to CSV mode and also
> using them for other purposes.
>
> The computation of padding is now done in the central
> callback, instead of every metric doing it manually.
> This makes it easier to add new metrics.
>
> v2: Refactor functions, printout now does more. Move
> shadow printing. Improve fallback callbacks. Don't
> use void * callback data.
> v3: Remove unnecessary hunk. Add typedef for new_line
> v4: Remove unnecessary hunk. Don't print metrics for CSV/interval
> mode yet. Move printout change to separate patch.
> v5: Fix bisect bugs. Avoid bogus frontend cycles printing.
> Fix indentation in different aggregation modes.
> v6: Delay newline handling
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2016-01-22 9:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 2:26 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-01-20 2:26 ` [PATCH 1/9] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2016-01-22 9:41 ` Jiri Olsa [this message]
2016-01-22 10:05 ` Jiri Olsa
2016-01-20 2:26 ` [PATCH 2/9] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2016-01-22 9:41 ` Jiri Olsa
2016-01-20 2:26 ` [PATCH 3/9] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2016-01-22 9:41 ` Jiri Olsa
2016-01-23 3:43 ` Andi Kleen
2016-01-23 16:19 ` Jiri Olsa
2016-01-26 23:57 ` Andi Kleen
2016-01-28 9:48 ` Jiri Olsa
2016-01-26 23:56 ` Andi Kleen
2016-01-20 2:26 ` [PATCH 4/9] perf, tools, stat: Implement CSV metrics output Andi Kleen
2016-01-22 9:57 ` Jiri Olsa
2016-01-20 2:26 ` [PATCH 5/9] perf, tools: Support metrics in --per-core/socket mode Andi Kleen
2016-01-20 2:26 ` [PATCH 6/9] perf, tools, stat: Document CSV format in manpage Andi Kleen
2016-01-22 10:03 ` Jiri Olsa
2016-01-22 10:08 ` Jiri Olsa
2016-01-23 3:43 ` Andi Kleen
2016-01-20 2:26 ` [PATCH 7/9] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-01-20 2:26 ` [PATCH 8/9] perf, tools: Add --metric-only support for -A Andi Kleen
2016-01-20 2:26 ` [PATCH 9/9] perf, tools, stat: Fix indentation of counter running printout Andi Kleen
2016-01-22 10:10 ` perf, tools: Refactor and support interval and CSV metrics Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160122094132.GA27246@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®