mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org, eranian@google.com,
	Michael Petlan <mpetlan@redhat.com>
Subject: Re: perf, tools: Refactor and support interval and CSV metrics
Date: Fri, 22 Jan 2016 11:10:03 +0100	[thread overview]
Message-ID: <20160122101003.GE11995@krava.brq.redhat.com> (raw)
In-Reply-To: <1453256812-24006-1-git-send-email-andi@firstfloor.org>

On Tue, Jan 19, 2016 at 06:26:43PM -0800, Andi Kleen wrote:
> [v5: Fix mainly bisect problems. No regressions introduced by one
> patch and fixed again later. Some minor fixes in addition]
> [v6: Fix running/noise printing patch.]
> [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was
> printed as 0]
> [v8: Minor fixes for review feedback. See changelog in patches.]
> [v9: Fix newline bug. Add support for -A for --metric-only]
> 
> Currently perf stat does not support printing computed metrics for interval (-I xxx)
> or CSV (-x,) mode. For example IPC or TSX metrics over time are quite useful to know.
> 
> This patch implements them. The main obstacle was that the
> metrics printing was all open coded all over the metrics computation code.
> The second patch refactors the metrics printing to work through call backs that
> can be more easily changed. This also cleans up the metrics printing significantly.
> The indentation is now handled through printf, no more need to manually count spaces.
> 
> Then based on that it implements metrics printing for CSV and interval mode,
> and finally a --metric-only mode.
> 
> Example output:
> 
> % perf stat  -I1000 -a sleep 1
> #          time              counts unit events                    metric                              multiplex
>      1.001301370       12020.049593      task-clock (msec)                                             (100.00%)
>      1.001301370              3,952      context-switches          #    0.329 K/sec                    (100.00%)
>      1.001301370                 69      cpu-migrations            #    0.006 K/sec                    (100.00%)
>      1.001301370                 76      page-faults               #    0.006 K/sec                  
>      1.001301370        386,582,789      cycles                    #    0.032 GHz                      (100.00%)
>      1.001301370        716,441,544      stalled-cycles-frontend   #  185.33% frontend cycles idle     (100.00%)
>      1.001301370    <not supported>      stalled-cycles-backend   
>      1.001301370        101,751,678      instructions              #    0.26  insn per cycle         
>      1.001301370                                                   #    7.04  stalled cycles per insn  (100.00%)
>      1.001301370         20,914,692      branches                  #    1.740 M/sec                    (100.00%)
>      1.001301370          1,943,630      branch-misses             #    9.29% of all branches        
> 
> CSV mode
> 
> % perf stat  -x, -I1000 -a sleep 1
>      1.000852081,12016.143006,,task-clock
>      1.000852081,4457,,context-switches,12015168277,100.00,0.371,K/sec
>      1.000852081,50,,cpu-migrations,12014024424,100.00,0.004,K/sec
>      1.000852081,76,,page-faults,12013076716,100.00,0.006,K/sec
>      1.000852081,515854373,,cycles,12011235336,100.00,0.043,GHz
>      1.000852081,1030742150,,stalled-cycles-frontend,12010984057,100.00,199.81,frontend cycles idle
>      1.000852081,<not supported>,,stalled-cycles-backend,0,100.00
>      1.000852081,116782495,,instructions,12011130729,100.00,0.23,insn per cycle
>      1.000852081,,,,12011130729,100.00,8.83,stalled cycles per insn
>      1.000852081,23748237,,branches,12010745125,100.00,1.976,M/sec
>      1.000852081,1976560,,branch-misses,12010501884,100.00,8.32,of all branches
> 
> Available in
> git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6 perf/stat-metrics-13

this looks like great test candidate for the testing
suite Michael is working on.. CC-ed

thanks,
jirka

  parent reply	other threads:[~2016-01-22 10:10 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20  2:26 Andi Kleen
2016-01-20  2:26 ` [PATCH 1/9] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2016-01-22  9:41   ` Jiri Olsa
2016-01-22 10:05   ` Jiri Olsa
2016-01-20  2:26 ` [PATCH 2/9] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2016-01-22  9:41   ` Jiri Olsa
2016-01-20  2:26 ` [PATCH 3/9] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2016-01-22  9:41   ` Jiri Olsa
2016-01-23  3:43     ` Andi Kleen
2016-01-23 16:19       ` Jiri Olsa
2016-01-26 23:57         ` Andi Kleen
2016-01-28  9:48           ` Jiri Olsa
2016-01-26 23:56     ` Andi Kleen
2016-01-20  2:26 ` [PATCH 4/9] perf, tools, stat: Implement CSV metrics output Andi Kleen
2016-01-22  9:57   ` Jiri Olsa
2016-01-20  2:26 ` [PATCH 5/9] perf, tools: Support metrics in --per-core/socket mode Andi Kleen
2016-01-20  2:26 ` [PATCH 6/9] perf, tools, stat: Document CSV format in manpage Andi Kleen
2016-01-22 10:03   ` Jiri Olsa
2016-01-22 10:08   ` Jiri Olsa
2016-01-23  3:43     ` Andi Kleen
2016-01-20  2:26 ` [PATCH 7/9] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-01-20  2:26 ` [PATCH 8/9] perf, tools: Add --metric-only support for -A Andi Kleen
2016-01-20  2:26 ` [PATCH 9/9] perf, tools, stat: Fix indentation of counter running printout Andi Kleen
2016-01-22 10:10 ` Jiri Olsa [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-03-03 23:57 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-03-07 10:08 ` Jiri Olsa
2016-03-07 18:22   ` Andi Kleen
2016-03-07 18:48     ` Jiri Olsa
2016-03-07 21:11       ` Andi Kleen
2016-03-10 11:34         ` Jiri Olsa
2016-03-03  0:24 Andi Kleen
2016-03-01 18:57 Andi Kleen
2016-03-01 19:05 ` Arnaldo Carvalho de Melo
2016-02-29 22:36 Andi Kleen
2016-03-01 13:07 ` Arnaldo Carvalho de Melo
2016-02-27  0:27 Andi Kleen
2016-02-17 22:43 Andi Kleen
2016-01-30 17:06 Andi Kleen
2016-01-27  0:42 Andi Kleen
2016-01-16  1:11 Andi Kleen
2016-01-16 20:21 ` Jiri Olsa
2016-01-18 22:25   ` Andi Kleen
2015-07-30  0:21 Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160122101003.GE11995@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mpetlan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®