mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Paul Kocialkowski <contact@paulk.fr>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: core: Use a bitfield for continuous_voltage_range
Date: Sat, 23 Jan 2016 15:16:16 +0000	[thread overview]
Message-ID: <20160123151616.GH6588@sirena.org.uk> (raw)
In-Reply-To: <1453498953.13870.41.camel@perches.com>

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

On Fri, Jan 22, 2016 at 01:42:33PM -0800, Joe Perches wrote:
> On Fri, 2016-01-22 at 21:31 +0000, Mark Brown wrote:

> > It adds up when you get more flags and these are not in the least bit
> > performance sensitive.

> Sure, but intelligibility is useful too.

I'm really not sure the use of small integers for boolean flags is going
to be an especially troubling barrier for people.

> Do you expect to have more than 4 of these flags?

It's plausible.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-01-23 15:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-21 20:24 Mark Brown
2016-01-21 20:24 ` [PATCH 2/2] regulator: core: Provide per-regulator runtime PM support Mark Brown
2016-01-21 21:49   ` kbuild test robot
2016-01-29 12:02   ` Paul Kocialkowski
2016-02-09 20:51   ` Paul Kocialkowski
2016-02-12 19:24     ` Paul Kocialkowski
2016-02-26  2:13       ` Mark Brown
2016-01-22 19:15 ` [PATCH 1/2] regulator: core: Use a bitfield for continuous_voltage_range Joe Perches
2016-01-22 21:31   ` Mark Brown
2016-01-22 21:42     ` Joe Perches
2016-01-23 15:16       ` Mark Brown [this message]
2016-04-21 16:11 ` Applied "regulator: core: Use a bitfield for continuous_voltage_range" to the regulator tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160123151616.GH6588@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=contact@paulk.fr \
    --cc=joe@perches.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®