mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
	acme@kernel.org, Brendan Gregg <brendan.d.gregg@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	"David S. Miller" <davem@davemloft.net>,
	He Kuang <hekuang@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
	Li Zefan <lizefan@huawei.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	pi3orama@163.com, Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/54] perf test: Add libbpf relocation checker
Date: Tue, 26 Jan 2016 12:58:50 -0200	[thread overview]
Message-ID: <20160126145850.GA3493@redhat.com> (raw)
In-Reply-To: <1453715801-7732-2-git-send-email-wangnan0@huawei.com>

Em Mon, Jan 25, 2016 at 09:55:48AM +0000, Wang Nan escreveu:
> There's a bug in LLVM that it can generate unneeded relocation
> information. See [1] and [2]. Libbpf should check the target section
> of a relocation symbol.
> 
> This patch adds a testcase which reference a global variable (BPF
> doesn't support global variable). Before fixing libbpf, the new test
> case can be loaded into kernel, the global variable acts like the first
> map. It is incorrect.
> 
> Result:
>  # ~/perf test BPF
>  37: Test BPF filter                                          :
>  37.1: Test basic BPF filtering                               : Ok
>  37.2: Test BPF prologue generation                           : Ok
>  37.3: Test BPF relocation checker                            : FAILED!
> 
>  # ~/perf test -v BPF
>  ...
>  libbpf: loading object '[bpf_relocation_test]' from buffer
>  libbpf: section .strtab, size 126, link 0, flags 0, type=3
>  libbpf: section .text, size 0, link 0, flags 6, type=1
>  libbpf: section .data, size 0, link 0, flags 3, type=1
>  libbpf: section .bss, size 0, link 0, flags 3, type=8
>  libbpf: section func=sys_write, size 104, link 0, flags 6, type=1
>  libbpf: found program func=sys_write
>  libbpf: section .relfunc=sys_write, size 16, link 10, flags 0, type=9
>  libbpf: section maps, size 16, link 0, flags 3, type=1
>  libbpf: maps in [bpf_relocation_test]: 16 bytes
>  libbpf: section license, size 4, link 0, flags 3, type=1
>  libbpf: license of [bpf_relocation_test] is GPL
>  libbpf: section version, size 4, link 0, flags 3, type=1
>  libbpf: kernel version of [bpf_relocation_test] is 40400
>  libbpf: section .symtab, size 144, link 1, flags 0, type=2
>  libbpf: map 0 is "my_table"
>  libbpf: collecting relocating info for: 'func=sys_write'
>  libbpf: relocation: insn_idx=7
>  Success unexpectedly: libbpf error when dealing with relocation

"Success unexpectedly?" Reading the code to try to grok this message...


- Arnaldo

>  test child finished with -1
>  ---- end ----
>  Test BPF filter subtest 2: FAILED!
> 
> [1] https://llvm.org/bugs/show_bug.cgi?id=26243
> [2] https://patchwork.ozlabs.org/patch/571385/
> 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Li Zefan <lizefan@huawei.com>
> Cc: pi3orama@163.com
> ---
>  tools/perf/Makefile.perf                      |  2 +-
>  tools/perf/tests/.gitignore                   |  1 +
>  tools/perf/tests/Build                        |  9 ++++-
>  tools/perf/tests/bpf-script-test-relocation.c | 50 +++++++++++++++++++++++++++
>  tools/perf/tests/bpf.c                        | 26 +++++++++++---
>  tools/perf/tests/llvm.c                       | 17 ++++++---
>  tools/perf/tests/llvm.h                       |  5 ++-
>  7 files changed, 98 insertions(+), 12 deletions(-)
>  create mode 100644 tools/perf/tests/bpf-script-test-relocation.c
> 
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 5d34815..97ce869 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -618,7 +618,7 @@ clean: $(LIBTRACEEVENT)-clean $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean
>  	$(call QUIET_CLEAN, core-progs) $(RM) $(ALL_PROGRAMS) perf perf-read-vdso32 perf-read-vdsox32
>  	$(call QUIET_CLEAN, core-gen)   $(RM)  *.spec *.pyc *.pyo */*.pyc */*.pyo $(OUTPUT)common-cmds.h TAGS tags cscope* $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)FEATURE-DUMP $(OUTPUT)util/*-bison* $(OUTPUT)util/*-flex* \
>  		$(OUTPUT)util/intel-pt-decoder/inat-tables.c $(OUTPUT)fixdep \
> -		$(OUTPUT)tests/llvm-src-{base,kbuild,prologue}.c
> +		$(OUTPUT)tests/llvm-src-{base,kbuild,prologue,relocation}.c
>  	$(QUIET_SUBDIR0)Documentation $(QUIET_SUBDIR1) clean
>  	$(python-clean)
>  
> diff --git a/tools/perf/tests/.gitignore b/tools/perf/tests/.gitignore
> index bf016c4..8cc30e7 100644
> --- a/tools/perf/tests/.gitignore
> +++ b/tools/perf/tests/.gitignore
> @@ -1,3 +1,4 @@
>  llvm-src-base.c
>  llvm-src-kbuild.c
>  llvm-src-prologue.c
> +llvm-src-relocation.c
> diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
> index 614899b..1ba628e 100644
> --- a/tools/perf/tests/Build
> +++ b/tools/perf/tests/Build
> @@ -31,7 +31,7 @@ perf-y += sample-parsing.o
>  perf-y += parse-no-sample-id-all.o
>  perf-y += kmod-path.o
>  perf-y += thread-map.o
> -perf-y += llvm.o llvm-src-base.o llvm-src-kbuild.o llvm-src-prologue.o
> +perf-y += llvm.o llvm-src-base.o llvm-src-kbuild.o llvm-src-prologue.o llvm-src-relocation.o
>  perf-y += bpf.o
>  perf-y += topology.o
>  perf-y += cpumap.o
> @@ -59,6 +59,13 @@ $(OUTPUT)tests/llvm-src-prologue.c: tests/bpf-script-test-prologue.c tests/Build
>  	$(Q)sed -e 's/"/\\"/g' -e 's/\(.*\)/"\1\\n"/g' $< >> $@
>  	$(Q)echo ';' >> $@
>  
> +$(OUTPUT)tests/llvm-src-relocation.c: tests/bpf-script-test-relocation.c tests/Build
> +	$(call rule_mkdir)
> +	$(Q)echo '#include <tests/llvm.h>' > $@
> +	$(Q)echo 'const char test_llvm__bpf_test_relocation[] =' >> $@
> +	$(Q)sed -e 's/"/\\"/g' -e 's/\(.*\)/"\1\\n"/g' $< >> $@
> +	$(Q)echo ';' >> $@
> +
>  ifeq ($(ARCH),$(filter $(ARCH),x86 arm arm64))
>  perf-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o
>  endif
> diff --git a/tools/perf/tests/bpf-script-test-relocation.c b/tools/perf/tests/bpf-script-test-relocation.c
> new file mode 100644
> index 0000000..93af774
> --- /dev/null
> +++ b/tools/perf/tests/bpf-script-test-relocation.c
> @@ -0,0 +1,50 @@
> +/*
> + * bpf-script-test-relocation.c
> + * Test BPF loader checking relocation
> + */
> +#ifndef LINUX_VERSION_CODE
> +# error Need LINUX_VERSION_CODE
> +# error Example: for 4.2 kernel, put 'clang-opt="-DLINUX_VERSION_CODE=0x40200" into llvm section of ~/.perfconfig'
> +#endif
> +#define BPF_ANY 0
> +#define BPF_MAP_TYPE_ARRAY 2
> +#define BPF_FUNC_map_lookup_elem 1
> +#define BPF_FUNC_map_update_elem 2
> +
> +static void *(*bpf_map_lookup_elem)(void *map, void *key) =
> +	(void *) BPF_FUNC_map_lookup_elem;
> +static void *(*bpf_map_update_elem)(void *map, void *key, void *value, int flags) =
> +	(void *) BPF_FUNC_map_update_elem;
> +
> +struct bpf_map_def {
> +	unsigned int type;
> +	unsigned int key_size;
> +	unsigned int value_size;
> +	unsigned int max_entries;
> +};
> +
> +#define SEC(NAME) __attribute__((section(NAME), used))
> +struct bpf_map_def SEC("maps") my_table = {
> +	.type = BPF_MAP_TYPE_ARRAY,
> +	.key_size = sizeof(int),
> +	.value_size = sizeof(int),
> +	.max_entries = 1,
> +};
> +
> +int this_is_a_global_val;
> +
> +SEC("func=sys_write")
> +int bpf_func__sys_write(void *ctx)
> +{
> +	int key = 0;
> +	int value = 0;
> +
> +	/*
> +	 * Incorrect relocation. Should not allow this program be
> +	 * loaded into kernel.
> +	 */
> +	bpf_map_update_elem(&this_is_a_global_val, &key, &value, 0);
> +	return 0;
> +}
> +char _license[] SEC("license") = "GPL";
> +int _version SEC("version") = LINUX_VERSION_CODE;
> diff --git a/tools/perf/tests/bpf.c b/tools/perf/tests/bpf.c
> index 33689a0..952ca99 100644
> --- a/tools/perf/tests/bpf.c
> +++ b/tools/perf/tests/bpf.c
> @@ -71,6 +71,15 @@ static struct {
>  		(NR_ITERS + 1) / 4,
>  	},
>  #endif
> +	{
> +		LLVM_TESTCASE_BPF_RELOCATION,
> +		"Test BPF relocation checker",
> +		"[bpf_relocation_test]",
> +		"fix 'perf test LLVM' first",
> +		"libbpf error when dealing with relocation",
> +		NULL,
> +		0,
> +	},
>  };
>  
>  static int do_test(struct bpf_object *obj, int (*func)(void),
> @@ -190,7 +199,7 @@ static int __test__bpf(int idx)
>  
>  	ret = test_llvm__fetch_bpf_obj(&obj_buf, &obj_buf_sz,
>  				       bpf_testcase_table[idx].prog_id,
> -				       true);
> +				       true, NULL);
>  	if (ret != TEST_OK || !obj_buf || !obj_buf_sz) {
>  		pr_debug("Unable to get BPF object, %s\n",
>  			 bpf_testcase_table[idx].msg_compile_fail);
> @@ -202,14 +211,21 @@ static int __test__bpf(int idx)
>  
>  	obj = prepare_bpf(obj_buf, obj_buf_sz,
>  			  bpf_testcase_table[idx].name);
> -	if (!obj) {
> +	if ((!!bpf_testcase_table[idx].target_func) != (!!obj)) {
> +		if (!obj)
> +			pr_debug("Fail to load BPF object: %s\n",
> +				 bpf_testcase_table[idx].msg_load_fail);
> +		else
> +			pr_debug("Success unexpectedly: %s\n",
> +				 bpf_testcase_table[idx].msg_load_fail);
>  		ret = TEST_FAIL;
>  		goto out;
>  	}
>  
> -	ret = do_test(obj,
> -		      bpf_testcase_table[idx].target_func,
> -		      bpf_testcase_table[idx].expect_result);
> +	if (obj)
> +		ret = do_test(obj,
> +			      bpf_testcase_table[idx].target_func,
> +			      bpf_testcase_table[idx].expect_result);
>  out:
>  	bpf__clear();
>  	return ret;
> diff --git a/tools/perf/tests/llvm.c b/tools/perf/tests/llvm.c
> index 06f45c1..70edcdf 100644
> --- a/tools/perf/tests/llvm.c
> +++ b/tools/perf/tests/llvm.c
> @@ -35,6 +35,7 @@ static int test__bpf_parsing(void *obj_buf __maybe_unused,
>  static struct {
>  	const char *source;
>  	const char *desc;
> +	bool should_load_fail;
>  } bpf_source_table[__LLVM_TESTCASE_MAX] = {
>  	[LLVM_TESTCASE_BASE] = {
>  		.source = test_llvm__bpf_base_prog,
> @@ -48,14 +49,19 @@ static struct {
>  		.source = test_llvm__bpf_test_prologue_prog,
>  		.desc = "Compile source for BPF prologue generation test",
>  	},
> +	[LLVM_TESTCASE_BPF_RELOCATION] = {
> +		.source = test_llvm__bpf_test_relocation,
> +		.desc = "Compile source for BPF relocation test",
> +		.should_load_fail = true,
> +	},
>  };
>  
> -
>  int
>  test_llvm__fetch_bpf_obj(void **p_obj_buf,
>  			 size_t *p_obj_buf_sz,
>  			 enum test_llvm__testcase idx,
> -			 bool force)
> +			 bool force,
> +			 bool *should_load_fail)
>  {
>  	const char *source;
>  	const char *desc;
> @@ -68,6 +74,8 @@ test_llvm__fetch_bpf_obj(void **p_obj_buf,
>  
>  	source = bpf_source_table[idx].source;
>  	desc = bpf_source_table[idx].desc;
> +	if (should_load_fail)
> +		*should_load_fail = bpf_source_table[idx].should_load_fail;
>  
>  	perf_config(perf_config_cb, NULL);
>  
> @@ -136,14 +144,15 @@ int test__llvm(int subtest)
>  	int ret;
>  	void *obj_buf = NULL;
>  	size_t obj_buf_sz = 0;
> +	bool should_load_fail = false;
>  
>  	if ((subtest < 0) || (subtest >= __LLVM_TESTCASE_MAX))
>  		return TEST_FAIL;
>  
>  	ret = test_llvm__fetch_bpf_obj(&obj_buf, &obj_buf_sz,
> -				       subtest, false);
> +				       subtest, false, &should_load_fail);
>  
> -	if (ret == TEST_OK) {
> +	if (ret == TEST_OK && !should_load_fail) {
>  		ret = test__bpf_parsing(obj_buf, obj_buf_sz);
>  		if (ret != TEST_OK) {
>  			pr_debug("Failed to parse test case '%s'\n",
> diff --git a/tools/perf/tests/llvm.h b/tools/perf/tests/llvm.h
> index 5150b4d..0eaa604 100644
> --- a/tools/perf/tests/llvm.h
> +++ b/tools/perf/tests/llvm.h
> @@ -7,14 +7,17 @@
>  extern const char test_llvm__bpf_base_prog[];
>  extern const char test_llvm__bpf_test_kbuild_prog[];
>  extern const char test_llvm__bpf_test_prologue_prog[];
> +extern const char test_llvm__bpf_test_relocation[];
>  
>  enum test_llvm__testcase {
>  	LLVM_TESTCASE_BASE,
>  	LLVM_TESTCASE_KBUILD,
>  	LLVM_TESTCASE_BPF_PROLOGUE,
> +	LLVM_TESTCASE_BPF_RELOCATION,
>  	__LLVM_TESTCASE_MAX,
>  };
>  
>  int test_llvm__fetch_bpf_obj(void **p_obj_buf, size_t *p_obj_buf_sz,
> -			     enum test_llvm__testcase index, bool force);
> +			     enum test_llvm__testcase index, bool force,
> +			     bool *should_load_fail);
>  #endif
> -- 
> 1.8.3.4

  reply	other threads:[~2016-01-26 14:58 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25  9:55 [GIT PULL 00/54] perf tools: Bugfix, BPF improvements and overwrite ring buffer support Wang Nan
2016-01-25  9:55 ` [PATCH 01/54] perf test: Add libbpf relocation checker Wang Nan
2016-01-26 14:58   ` Arnaldo Carvalho de Melo [this message]
2016-01-26 15:07     ` Arnaldo Carvalho de Melo
2016-02-03 10:13   ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25  9:55 ` [PATCH 02/54] perf bpf: Check relocation target section Wang Nan
2016-02-03 10:14   ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25  9:55 ` [PATCH 03/54] tools build: Allow subprojects select all feature checkers Wang Nan
2016-02-03 10:14   ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25  9:55 ` [PATCH 04/54] perf build: Select all feature checkers for feature-dump Wang Nan
2016-02-03 10:14   ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25  9:55 ` [PATCH 05/54] perf build: Use feature dump file for build-test Wang Nan
2016-01-26 16:59   ` Arnaldo Carvalho de Melo
2016-01-27  2:36     ` Wangnan (F)
2016-01-27 13:54       ` Arnaldo Carvalho de Melo
2016-01-27 11:22     ` [PATCH] tools build: Check basic headers for test-compile feature checker Wang Nan
2016-01-27 13:23       ` Jiri Olsa
2016-01-27 13:55         ` Arnaldo Carvalho de Melo
2016-02-03 10:15       ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25  9:55 ` [PATCH 06/54] perf test: Check environment before start real BPF test Wang Nan
2016-02-03 10:18   ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25  9:55 ` [PATCH 07/54] perf tools: Fix symbols searching for offline module in buildid-cache Wang Nan
2016-01-25  9:55 ` [PATCH 08/54] perf test: Improve bp_signal Wang Nan
2016-02-03 10:18   ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25  9:55 ` [PATCH 09/54] perf tools: Add API to config maps in bpf object Wang Nan
2016-02-03 23:29   ` Arnaldo Carvalho de Melo
2016-02-04 12:59     ` Wangnan (F)
2016-01-25  9:55 ` [PATCH 10/54] perf tools: Enable BPF object configure syntax Wang Nan
2016-01-25  9:55 ` [PATCH 11/54] perf record: Apply config to BPF objects before recording Wang Nan
2016-01-25  9:55 ` [PATCH 12/54] perf tools: Enable passing event to BPF object Wang Nan
2016-01-25  9:56 ` [PATCH 13/54] perf tools: Support perf event alias name Wang Nan
2016-02-03 23:35   ` Arnaldo Carvalho de Melo
2016-01-25  9:56 ` [PATCH 14/54] perf tools: Support setting different slots in a BPF map separately Wang Nan
2016-01-25  9:56 ` [PATCH 15/54] perf tools: Enable indices setting syntax for BPF maps Wang Nan
2016-01-25  9:56 ` [PATCH 16/54] perf tools: Introduce bpf-output event Wang Nan
2016-01-25  9:56 ` [PATCH 17/54] perf data: Support converting data from bpf_perf_event_output() Wang Nan
2016-01-25  9:56 ` [PATCH 18/54] perf core: Introduce new ioctl options to pause and resume ring buffer Wang Nan
2016-01-25  9:56 ` [PATCH 19/54] perf core: Set event's default overflow_handler Wang Nan
2016-01-25  9:56 ` [PATCH 20/54] perf core: Prepare writing into ring buffer from end Wang Nan
2016-01-25  9:56 ` [PATCH 21/54] perf core: Add backward attribute to perf event Wang Nan
2016-01-25  9:56 ` [PATCH 22/54] perf core: Reduce perf event output overhead by new overflow handler Wang Nan
2016-01-25  9:56 ` [PATCH 23/54] perf tools: Introduce API to pause ring buffer Wang Nan
2016-01-25  9:56 ` [PATCH 24/54] perf tools: Only validate is_pos for tracking evsels Wang Nan
2016-01-25  9:56 ` [PATCH 25/54] perf tools: Print write_backward value in perf_event_attr__fprintf Wang Nan
2016-01-25  9:56 ` [PATCH 26/54] perf tools: Move timestamp creation to util Wang Nan
2016-02-03 10:18   ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25  9:56 ` [PATCH 27/54] perf tools: Make ordered_events reusable Wang Nan
2016-01-25  9:56 ` [PATCH 28/54] perf record: Extract synthesize code to record__synthesize() Wang Nan
2016-01-29 20:37   ` Arnaldo Carvalho de Melo
2016-01-25  9:56 ` [PATCH 29/54] perf tools: Add perf_data_file__switch() helper Wang Nan
2016-01-25  9:56 ` [PATCH 30/54] perf record: Turns auxtrace_snapshot_enable into 3 states Wang Nan
2016-01-25  9:56 ` [PATCH 31/54] perf record: Introduce record__finish_output() to finish a perf.data Wang Nan
2016-01-25  9:56 ` [PATCH 32/54] perf record: Use OPT_BOOLEAN_SET for buildid cache related options Wang Nan
2016-02-03 10:19   ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25  9:56 ` [PATCH 33/54] perf record: Add '--timestamp-filename' option to append timestamp to output filename Wang Nan
2016-01-25  9:56 ` [PATCH 34/54] perf record: Split output into multiple files via '--switch-output' Wang Nan
2016-01-25  9:56 ` [PATCH 35/54] perf record: Force enable --timestamp-filename when --switch-output is provided Wang Nan
2016-01-25  9:56 ` [PATCH 36/54] perf record: Disable buildid cache options by default in switch output mode Wang Nan
2016-01-25  9:56 ` [PATCH 37/54] perf record: Re-synthesize tracking events after output switching Wang Nan
2016-01-25  9:56 ` [PATCH 38/54] perf record: Generate tracking events for process forked by perf Wang Nan
2016-01-25  9:56 ` [PATCH 39/54] perf record: Ensure return non-zero rc when mmap fail Wang Nan
2016-01-25  9:56 ` [PATCH 40/54] perf record: Prevent reading invalid data in record__mmap_read Wang Nan
2016-01-25  9:56 ` [PATCH 41/54] perf tools: Add evlist channel helpers Wang Nan
2016-01-25  9:56 ` [PATCH 42/54] perf tools: Automatically add new channel according to evlist Wang Nan
2016-01-25  9:56 ` [PATCH 43/54] perf tools: Operate multiple channels Wang Nan
2016-01-25  9:56 ` [PATCH 44/54] perf tools: Squash overwrite setting into channel Wang Nan
2016-01-25  9:56 ` [PATCH 45/54] perf record: Don't read from and poll overwrite channel Wang Nan
2016-01-25  9:56 ` [PATCH 46/54] perf record: Don't poll on " Wang Nan
2016-01-25  9:56 ` [PATCH 47/54] perf tools: Detect avalibility of write_backward Wang Nan
2016-01-25  9:56 ` [PATCH 48/54] perf tools: Enable overwrite settings Wang Nan
2016-01-25  9:56 ` [PATCH 49/54] perf tools: Set write_backward attribut bit for overwrite events Wang Nan
2016-01-25  9:56 ` [PATCH 50/54] perf record: Toggle overwrite ring buffer for reading Wang Nan
2016-01-26  8:25   ` Wangnan (F)
2016-01-25  9:56 ` [PATCH 51/54] perf record: Rename variable to make code clear Wang Nan
2016-01-25  9:56 ` [PATCH 52/54] perf record: Read from backward ring buffer Wang Nan
2016-01-25  9:56 ` [PATCH 53/54] perf record: Allow generate tracking events at the end of output Wang Nan
2016-01-25  9:56 ` [PATCH 54/54] perf tools: Don't warn about out of order event if write_backward is used Wang Nan
2016-01-26  9:11 ` [offlist] Re: [GIT PULL 00/54] perf tools: Bugfix, BPF improvements and overwrite ring buffer support Wangnan (F)
2016-01-26 14:11   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160126145850.GA3493@redhat.com \
    --to=acme@redhat.com \
    --cc=acme@kernel.org \
    --cc=ast@kernel.org \
    --cc=brendan.d.gregg@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pi3orama@163.com \
    --cc=wangnan0@huawei.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome