From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@redhat.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
He Kuang <hekuang@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
Li Zefan <lizefan@huawei.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
pi3orama@163.com, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/54] perf tools: Support perf event alias name
Date: Wed, 3 Feb 2016 21:35:55 -0200 [thread overview]
Message-ID: <20160203233555.GC12194@redhat.com> (raw)
In-Reply-To: <1453715801-7732-14-git-send-email-wangnan0@huawei.com>
Em Mon, Jan 25, 2016 at 09:56:00AM +0000, Wang Nan escreveu:
> From: He Kuang <hekuang@huawei.com>
>
> This patch is useful when trying to pass a perf event to BPF map.
> Before this patch we are unable to pass an event with config term to
> BPF maps. For example:
>
> # perf record -a -e cycles/no-inherit,period=0x7fffffffffffffff/ \
> -e './test_bpf_map_2.c/maps:pmu_map.event=cycles/no-inherit,period=0x7fffffffffffffff//' ls /
> event syntax error: '..ps:pmu_map.event=cycles/'
> \___ Event not found for map setting
>
> Because those '/' and ',' embarrass parser.
>
> This patch adds new bison rules for specifying an alias name to a perf
> event, which allows cmdline refer to previous defined perf event through
> its name. With this patch user can give alias name to a perf event using
> following cmdline. The above goal can be achieved using:
>
> # perf record -a -e cyc=cycles/no-inherit,period=0x7fffffffffffffff/ \
> -e './test_bpf_map_2.c/maps:pmu_map.event=cyc/' ls /
In another thread Jiri suggested this as a way to get an alias
associated with some event:
-----------------------------------------------------------------
On Tue, Feb 02, 2016 at 05:24:16PM +0100, Andreas Hollmann wrote:
> Jiri, how do you handle raw counters with this python stat__*
> callback? What is the name of the callback?
you can use 'name' term like:
perf stat -e cycles,"cpu/config=0x6530160,name=krava/"
and use following callback in your script:
def stat__krava(cpu, thread, time, val, ena, run):
-----------------------------------------------------------------
Can't we go with that existing syntax? Jiri?
That would be:
# perf record -a -e cycles/no-inherit,period=0x7fffffffffffffff,name=cyc/ \
-e './test_bpf_map_2.c/maps:pmu_map.event=cyc/' ls /
Your way is shorter, but we already have this name=foo method :-\
- Arnaldo
next prev parent reply other threads:[~2016-02-03 23:36 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 9:55 [GIT PULL 00/54] perf tools: Bugfix, BPF improvements and overwrite ring buffer support Wang Nan
2016-01-25 9:55 ` [PATCH 01/54] perf test: Add libbpf relocation checker Wang Nan
2016-01-26 14:58 ` Arnaldo Carvalho de Melo
2016-01-26 15:07 ` Arnaldo Carvalho de Melo
2016-02-03 10:13 ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25 9:55 ` [PATCH 02/54] perf bpf: Check relocation target section Wang Nan
2016-02-03 10:14 ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25 9:55 ` [PATCH 03/54] tools build: Allow subprojects select all feature checkers Wang Nan
2016-02-03 10:14 ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25 9:55 ` [PATCH 04/54] perf build: Select all feature checkers for feature-dump Wang Nan
2016-02-03 10:14 ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25 9:55 ` [PATCH 05/54] perf build: Use feature dump file for build-test Wang Nan
2016-01-26 16:59 ` Arnaldo Carvalho de Melo
2016-01-27 2:36 ` Wangnan (F)
2016-01-27 13:54 ` Arnaldo Carvalho de Melo
2016-01-27 11:22 ` [PATCH] tools build: Check basic headers for test-compile feature checker Wang Nan
2016-01-27 13:23 ` Jiri Olsa
2016-01-27 13:55 ` Arnaldo Carvalho de Melo
2016-02-03 10:15 ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25 9:55 ` [PATCH 06/54] perf test: Check environment before start real BPF test Wang Nan
2016-02-03 10:18 ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25 9:55 ` [PATCH 07/54] perf tools: Fix symbols searching for offline module in buildid-cache Wang Nan
2016-01-25 9:55 ` [PATCH 08/54] perf test: Improve bp_signal Wang Nan
2016-02-03 10:18 ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25 9:55 ` [PATCH 09/54] perf tools: Add API to config maps in bpf object Wang Nan
2016-02-03 23:29 ` Arnaldo Carvalho de Melo
2016-02-04 12:59 ` Wangnan (F)
2016-01-25 9:55 ` [PATCH 10/54] perf tools: Enable BPF object configure syntax Wang Nan
2016-01-25 9:55 ` [PATCH 11/54] perf record: Apply config to BPF objects before recording Wang Nan
2016-01-25 9:55 ` [PATCH 12/54] perf tools: Enable passing event to BPF object Wang Nan
2016-01-25 9:56 ` [PATCH 13/54] perf tools: Support perf event alias name Wang Nan
2016-02-03 23:35 ` Arnaldo Carvalho de Melo [this message]
2016-01-25 9:56 ` [PATCH 14/54] perf tools: Support setting different slots in a BPF map separately Wang Nan
2016-01-25 9:56 ` [PATCH 15/54] perf tools: Enable indices setting syntax for BPF maps Wang Nan
2016-01-25 9:56 ` [PATCH 16/54] perf tools: Introduce bpf-output event Wang Nan
2016-01-25 9:56 ` [PATCH 17/54] perf data: Support converting data from bpf_perf_event_output() Wang Nan
2016-01-25 9:56 ` [PATCH 18/54] perf core: Introduce new ioctl options to pause and resume ring buffer Wang Nan
2016-01-25 9:56 ` [PATCH 19/54] perf core: Set event's default overflow_handler Wang Nan
2016-01-25 9:56 ` [PATCH 20/54] perf core: Prepare writing into ring buffer from end Wang Nan
2016-01-25 9:56 ` [PATCH 21/54] perf core: Add backward attribute to perf event Wang Nan
2016-01-25 9:56 ` [PATCH 22/54] perf core: Reduce perf event output overhead by new overflow handler Wang Nan
2016-01-25 9:56 ` [PATCH 23/54] perf tools: Introduce API to pause ring buffer Wang Nan
2016-01-25 9:56 ` [PATCH 24/54] perf tools: Only validate is_pos for tracking evsels Wang Nan
2016-01-25 9:56 ` [PATCH 25/54] perf tools: Print write_backward value in perf_event_attr__fprintf Wang Nan
2016-01-25 9:56 ` [PATCH 26/54] perf tools: Move timestamp creation to util Wang Nan
2016-02-03 10:18 ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25 9:56 ` [PATCH 27/54] perf tools: Make ordered_events reusable Wang Nan
2016-01-25 9:56 ` [PATCH 28/54] perf record: Extract synthesize code to record__synthesize() Wang Nan
2016-01-29 20:37 ` Arnaldo Carvalho de Melo
2016-01-25 9:56 ` [PATCH 29/54] perf tools: Add perf_data_file__switch() helper Wang Nan
2016-01-25 9:56 ` [PATCH 30/54] perf record: Turns auxtrace_snapshot_enable into 3 states Wang Nan
2016-01-25 9:56 ` [PATCH 31/54] perf record: Introduce record__finish_output() to finish a perf.data Wang Nan
2016-01-25 9:56 ` [PATCH 32/54] perf record: Use OPT_BOOLEAN_SET for buildid cache related options Wang Nan
2016-02-03 10:19 ` [tip:perf/core] " tip-bot for Wang Nan
2016-01-25 9:56 ` [PATCH 33/54] perf record: Add '--timestamp-filename' option to append timestamp to output filename Wang Nan
2016-01-25 9:56 ` [PATCH 34/54] perf record: Split output into multiple files via '--switch-output' Wang Nan
2016-01-25 9:56 ` [PATCH 35/54] perf record: Force enable --timestamp-filename when --switch-output is provided Wang Nan
2016-01-25 9:56 ` [PATCH 36/54] perf record: Disable buildid cache options by default in switch output mode Wang Nan
2016-01-25 9:56 ` [PATCH 37/54] perf record: Re-synthesize tracking events after output switching Wang Nan
2016-01-25 9:56 ` [PATCH 38/54] perf record: Generate tracking events for process forked by perf Wang Nan
2016-01-25 9:56 ` [PATCH 39/54] perf record: Ensure return non-zero rc when mmap fail Wang Nan
2016-01-25 9:56 ` [PATCH 40/54] perf record: Prevent reading invalid data in record__mmap_read Wang Nan
2016-01-25 9:56 ` [PATCH 41/54] perf tools: Add evlist channel helpers Wang Nan
2016-01-25 9:56 ` [PATCH 42/54] perf tools: Automatically add new channel according to evlist Wang Nan
2016-01-25 9:56 ` [PATCH 43/54] perf tools: Operate multiple channels Wang Nan
2016-01-25 9:56 ` [PATCH 44/54] perf tools: Squash overwrite setting into channel Wang Nan
2016-01-25 9:56 ` [PATCH 45/54] perf record: Don't read from and poll overwrite channel Wang Nan
2016-01-25 9:56 ` [PATCH 46/54] perf record: Don't poll on " Wang Nan
2016-01-25 9:56 ` [PATCH 47/54] perf tools: Detect avalibility of write_backward Wang Nan
2016-01-25 9:56 ` [PATCH 48/54] perf tools: Enable overwrite settings Wang Nan
2016-01-25 9:56 ` [PATCH 49/54] perf tools: Set write_backward attribut bit for overwrite events Wang Nan
2016-01-25 9:56 ` [PATCH 50/54] perf record: Toggle overwrite ring buffer for reading Wang Nan
2016-01-26 8:25 ` Wangnan (F)
2016-01-25 9:56 ` [PATCH 51/54] perf record: Rename variable to make code clear Wang Nan
2016-01-25 9:56 ` [PATCH 52/54] perf record: Read from backward ring buffer Wang Nan
2016-01-25 9:56 ` [PATCH 53/54] perf record: Allow generate tracking events at the end of output Wang Nan
2016-01-25 9:56 ` [PATCH 54/54] perf tools: Don't warn about out of order event if write_backward is used Wang Nan
2016-01-26 9:11 ` [offlist] Re: [GIT PULL 00/54] perf tools: Bugfix, BPF improvements and overwrite ring buffer support Wangnan (F)
2016-01-26 14:11 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203233555.GC12194@redhat.com \
--to=acme@redhat.com \
--cc=ast@kernel.org \
--cc=brendan.d.gregg@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome