From: "Michael S. Tsirkin" <mst@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
the arch/x86 maintainers <x86@kernel.org>,
Davidlohr Bueso <dbueso@suse.de>,
"H. Peter Anvin" <hpa@zytor.com>,
virtualization <virtualization@lists.linux-foundation.org>,
Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@amacapital.net>,
Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
Andrey Konovalov <andreyknvl@google.com>,
Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH v4 5/5] x86: drop mfence in favor of lock+addl
Date: Wed, 27 Jan 2016 19:56:37 +0200 [thread overview]
Message-ID: <20160127195314-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <CA+55aFzcDiKjz8yzRf9ET7Qc-qeNFP5bO0qW7o2cB9G9=yXHng@mail.gmail.com>
On Wed, Jan 27, 2016 at 09:37:45AM -0800, Linus Torvalds wrote:
> On Wed, Jan 27, 2016 at 7:10 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > -#define __smp_mb() mb()
> > +#define __smp_mb() asm volatile("lock; addl $0,-4(%%esp)" ::: "memory", "cc")
>
> So this doesn't look right for x86-64. Using %esp rather than %rsp.
> How did that even work for you?
>
> Linus
Oops, didn't test this version properly.
Pls disregard, I'll repost after some proper testing.
--
MST
prev parent reply other threads:[~2016-01-27 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 15:10 [PATCH v4 0/5] x86: faster smp_mb()+documentation tweaks Michael S. Tsirkin
2016-01-27 15:10 ` [PATCH v4 1/5] x86: add cc clobber for addl Michael S. Tsirkin
2016-01-27 15:10 ` [PATCH v4 2/5] x86: drop a comment left over from X86_OOSTORE Michael S. Tsirkin
2016-01-27 15:10 ` [PATCH v4 3/5] x86: tweak the comment about use of wmb for IO Michael S. Tsirkin
2016-01-27 15:10 ` [PATCH v4 4/5] x86: use mb() around clflush Michael S. Tsirkin
2016-01-27 15:10 ` [PATCH v4 5/5] x86: drop mfence in favor of lock+addl Michael S. Tsirkin
2016-01-27 17:37 ` Linus Torvalds
2016-01-27 17:56 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127195314-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=andreyknvl@google.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome