From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Zhouyi Zhou <yizhouzhou@ict.ac.cn>,
Zhouyi Zhou <zhouzhouyi@gmail.com>,
pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu,
davem@davemloft.net, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] netfilter: h323: avoid potential attack
Date: Thu, 28 Jan 2016 14:15:57 +0000 [thread overview]
Message-ID: <20160128141557.74ad75f0@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1453989650.7627.30.camel@edumazet-glaptop2.roam.corp.google.com>
On Thu, 28 Jan 2016 06:00:50 -0800
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Thu, 2016-01-28 at 21:14 +0800, Zhouyi Zhou wrote:
>
> > My patch is intend to prevent kernel panic, to prevent reading garbage
> > or read data from a prior frame and leak secrets, the prototypes of the
> > get_h2x5_addr functions and the functions that call get_h2x5_addr should
> > be changed, should we do this?
>
> In term of security, panics are better than allowing attacker to read
> data from other people, like a password.
>
> BTW, are you able to trigger any panic ?
We have a smattering of panics in this code in bugzilla going back years.
https://bugzilla.kernel.org/show_bug.cgi?id=12473
etc
Alan
next prev parent reply other threads:[~2016-01-28 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1453971597-4811-1-git-send-email-zhouzhouyi@gmail.com>
[not found] ` <1453985821.7627.17.camel@edumazet-glaptop2.roam.corp.google.com>
2016-01-28 13:14 ` Zhouyi Zhou
2016-01-28 14:00 ` Eric Dumazet
2016-01-28 14:07 ` Eric Dumazet
2016-01-28 14:15 ` One Thousand Gnomes [this message]
[not found] ` <20160128142959.GB30994@breakpoint.cc>
2016-01-28 15:13 ` Zhouyi Zhou
2016-01-28 9:34 Zhouyi Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128141557.74ad75f0@lxorguk.ukuu.org.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=yizhouzhou@ict.ac.cn \
--cc=zhouzhouyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®