* Re: [PATCH] ASoC: pcm3168a: Call clk_set_rate in pcm3168a_set_dai_sysclk
[not found] <1454000060-8407-1-git-send-email-Damien.Horsley@imgtec.com>
@ 2016-01-28 23:15 ` Mark Brown
0 siblings, 0 replies; only message in thread
From: Mark Brown @ 2016-01-28 23:15 UTC (permalink / raw)
To: Damien Horsley
Cc: alsa-devel, Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
On Thu, Jan 28, 2016 at 04:54:20PM +0000, Damien Horsley wrote:
> + ret = clk_set_rate(pcm3168a->scki, freq);
> + if (ret)
> + return ret;
> +
> pcm3168a->sysclk = freq;
Since the clock appears to be mandatory in this driver (good!) why are
we even storing sysclk? Just remove it, the driver never actually used
it anyway.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-01-28 23:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1454000060-8407-1-git-send-email-Damien.Horsley@imgtec.com>
2016-01-28 23:15 ` [PATCH] ASoC: pcm3168a: Call clk_set_rate in pcm3168a_set_dai_sysclk Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome