From: Mark Brown <broonie@kernel.org>
To: John Crispin <blogic@openwrt.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
chen.zhong@mediatek.com, HenryC.Chen@mediatek.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH V5 1/2] regulator: Add document for MT6323 regulator
Date: Tue, 9 Feb 2016 12:41:33 +0000 [thread overview]
Message-ID: <20160209124133.GE13270@sirena.org.uk> (raw)
In-Reply-To: <1454874037-38905-1-git-send-email-blogic@openwrt.org>
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
On Sun, Feb 07, 2016 at 08:40:36PM +0100, John Crispin wrote:
> +Required properties:
> +- compatible: "mediatek,mt6323-regulator"
I'm really not happy with MFD subfunctions like this which add no
information over the parent device name appearing directly in the
binding, it results in us putting Linux specifics about how we split the
device up into the driver. It's not like this could realistically be
used separately to the parent device. Just have the MFD create the
device directly or if the individual regulators are reusable IPs which
can share a driver then describe them as such in the DT.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-09 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 19:40 John Crispin
2016-02-07 19:40 ` [PATCH V5 2/2] regulator: mt6323: Add support " John Crispin
2016-02-09 12:36 ` Mark Brown
2016-02-08 21:24 ` [PATCH V5 1/2] regulator: Add document " Rob Herring
2016-02-09 12:41 ` Mark Brown [this message]
2016-02-09 12:45 ` John Crispin
2016-02-09 15:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209124133.GE13270@sirena.org.uk \
--to=broonie@kernel.org \
--cc=HenryC.Chen@mediatek.com \
--cc=blogic@openwrt.org \
--cc=chen.zhong@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome