Re: [PATCH v4 2/4] modules: set mod->state to MODULE_STATE_GOING before going notifiers are called

[Josh Poimboeuf <jpoimboe@redhat.com>]

On Mon, Feb 08, 2016 at 11:50:22PM -0500, Jessica Yu wrote:
> In load_module(), the going notifiers are called during error handling when
> an error occurs after the coming notifiers have already been called.
> However, a module's state is still MODULE_STATE_COMING when the going
> notifiers are called in the error path. To be consistent, also set
> mod->state to MODULE_STATE_GOING before calling the going notifiers.
> 
> Signed-off-by: Jessica Yu <jeyu@redhat.com>

Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>

> ---
>  kernel/module.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index a174335..77f6791 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -3548,6 +3548,7 @@ static int load_module(struct load_info *info, const char __user *uargs,
>  	return do_init_module(mod);
>  
>   coming_cleanup:
> +	mod->state = MODULE_STATE_GOING;
>  	blocking_notifier_call_chain(&module_notify_list,
>  				     MODULE_STATE_GOING, mod);
>  
> -- 
> 2.4.3
> 

-- 
Josh