From: "Gabriel L. Somlo" <somlo@cmu.edu>
To: Valentin Rothberg <valentin.rothberg@posteo.net>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Andreas Ziegler <andreas.ziegler@fau.de>
Subject: Re: [PATCH v2] firmware: qemu_fw_cfg.c: fix typo FW_CFG_DATA_OFF
Date: Thu, 11 Feb 2016 07:12:43 -0500 [thread overview]
Message-ID: <20160211121219.GA15680@GLSMBP.INI.CMU.EDU> (raw)
In-Reply-To: <1455189543-42347-1-git-send-email-valentin.rothberg@posteo.net>
On Thu, Feb 11, 2016 at 12:19:03PM +0100, Valentin Rothberg wrote:
> s/FW_CTRL_DATA_OFF/FW_CFG_DATA_OFF/
Thanks for catching that !
Acked-by: Gabriel Somlo <somlo@cmu.edu>
>
> Signed-off-by: Valentin Rothberg <valentin.rothberg@posteo.net>
> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
> ---
> v2: corrected typo in signed-off-by
>
> drivers/firmware/qemu_fw_cfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 19f6851be87f..fedbff55a7f3 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -98,7 +98,7 @@ static void fw_cfg_io_cleanup(void)
> }
>
> /* arch-specific ctrl & data register offsets are not available in ACPI, DT */
> -#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CTRL_DATA_OFF))
> +#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CFG_DATA_OFF))
> # if (defined(CONFIG_ARM) || defined(CONFIG_ARM64))
> # define FW_CFG_CTRL_OFF 0x08
> # define FW_CFG_DATA_OFF 0x00
> --
> 2.5.0
>
prev parent reply other threads:[~2016-02-11 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 11:12 [PATCH] " Valentin Rothberg
2016-02-11 11:19 ` [PATCH v2] " Valentin Rothberg
2016-02-11 12:12 ` Gabriel L. Somlo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211121219.GA15680@GLSMBP.INI.CMU.EDU \
--to=somlo@cmu.edu \
--cc=andreas.ziegler@fau.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valentin.rothberg@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®