From: Andi Shyti <andi.shyti@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers
Date: Mon, 15 Feb 2016 15:37:07 +0900 [thread overview]
Message-ID: <20160215063707.GC10719@samsunx.samsung> (raw)
In-Reply-To: <1455250463-5955-1-git-send-email-javier@osg.samsung.com>
On Fri, Feb 12, 2016 at 01:14:23AM -0300, Javier Martinez Canillas wrote:
> The max77686 and max77802 regulator drivers are for sub-devices of a MFD
> driver for some PMIC blocks. But the same object file name (max77686.o)
> was used for both the common MFD driver and the max77686 regulator one.
>
> This confuses kbuild if both drivers are built as module causing the MFD
> driver to not be copied when installing the modules.
>
> Also, max77{686,802} are a quite generic name for MFD subdevices drivers
> so it is better to rename them to max77{686,802}-regulator like it's the
> case for most regulator drivers.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Looks good.
Reviewed-by: Andi Shyti <andi.shyti@samsung.com>
Andi
prev parent reply other threads:[~2016-02-15 6:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 4:14 Javier Martinez Canillas
2016-02-14 6:53 ` Krzysztof Kozlowski
2016-02-15 14:44 ` Javier Martinez Canillas
2016-02-15 6:37 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215063707.GC10719@samsunx.samsung \
--to=andi.shyti@samsung.com \
--cc=broonie@kernel.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®