From: Jiri Olsa <jolsa@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 0/5] perf tools: Store CPU cache details under perf data
Date: Tue, 16 Feb 2016 12:28:14 +0100 [thread overview]
Message-ID: <20160216112814.GA24086@krava.brq.redhat.com> (raw)
In-Reply-To: <20160216081413.GA31489@gmail.com>
On Tue, Feb 16, 2016 at 09:14:13AM +0100, Ingo Molnar wrote:
>
> * Jiri Olsa <jolsa@kernel.org> wrote:
>
> > hi,
> > adding support to store CPU cache details under perf data.
> >
> > $ perf report --header-only -I
> > ...
> > # cache info:
> > # L1 Data 32K [0-1]
> > # L1 Instruction 32K [0-1]
> > # L1 Data 32K [2-3]
> > # L1 Instruction 32K [2-3]
> > # L2 Unified 256K [0-1]
> > # L2 Unified 256K [2-3]
> > # L3 Unified 4096K [0-3]
>
> Very small UI nit, wouldn't it be nicer if this displayed tabular output, and if
> numbers were adjusted to their decimal point, i.e. something like:
>
> > # CPU cache info:
> > # L1 Data 32K [0-1]
> > # L1 Instruction 32K [0-1]
> > # L1 Data 32K [2-3]
> > # L1 Instruction 32K [2-3]
> > # L2 Unified 256K [0-1]
> > # L2 Unified 256K [2-3]
> > # L3 Unified 4096K [0-3]
>
> (Also note that it says 'CPU cache info' - there are a lot of caches in the
> system.)
yep, looks better.. will change
thanks,
jirka
prev parent reply other threads:[~2016-02-16 11:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 16:03 Jiri Olsa
2016-02-14 16:03 ` [PATCH 1/5] tools lib api: Add debug output support Jiri Olsa
2016-02-17 12:07 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-02-14 16:03 ` [PATCH 2/5] tools lib api fs: Move filename__read_str into api/fs/fs.c Jiri Olsa
2016-02-17 12:07 ` [tip:perf/core] tools lib api fs: Adopt filename__read_str from perf tip-bot for Jiri Olsa
2016-02-14 16:03 ` [PATCH 3/5] tools lib api fs: Add sysfs__read_str function Jiri Olsa
2016-02-17 12:07 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-02-14 16:03 ` [PATCH 4/5] perf tools: Initialize libapi debug output Jiri Olsa
2016-02-17 12:08 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-02-14 16:03 ` [PATCH 5/5] perf tools: Add perf data cache feature Jiri Olsa
2016-02-16 12:11 ` [PATCHv2 " Jiri Olsa
2016-02-16 14:22 ` Namhyung Kim
2016-02-16 15:01 ` [PATCHv3 " Jiri Olsa
2016-02-16 15:29 ` Arnaldo Carvalho de Melo
2016-02-16 15:48 ` Arnaldo Carvalho de Melo
2016-02-17 12:08 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-02-16 8:14 ` [PATCH 0/5] perf tools: Store CPU cache details under perf data Ingo Molnar
2016-02-16 11:28 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216112814.GA24086@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®