From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: linux-kernel@vger.kernel.org, julia.lawall@lip6.fr
Subject: Re: [PATCH] goldfish: Return proper error code
Date: Wed, 17 Feb 2016 18:41:26 +0000 [thread overview]
Message-ID: <20160217184126.59c0ae36@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20160217172329.GA9026@amitoj-Inspiron-3542>
On Wed, 17 Feb 2016 22:53:29 +0530
Amitoj Kaur Chawla <amitoj1606@gmail.com> wrote:
> This change has been made with the goal that kernel functions should
> return something more descriptive than -1 on failure.
>
> Change the return value on valid_batchbuffer_addr() failure from -1
> to -EINVAL.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
NAK. It's not user visible, it's a piece of code that has a pile of other
more important fixes needed first, and it's also as far as possible kept
aligned with the Android upstream.
If it were some random otherwise unchanging bit of code then it might
just about make sense but in this case no - especially when you only
change one of the two returns of -1 !
Alan
next prev parent reply other threads:[~2016-02-17 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 17:23 Amitoj Kaur Chawla
2016-02-17 18:41 ` One Thousand Gnomes [this message]
2016-02-17 19:20 ` Julia Lawall
2016-02-17 19:27 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217184126.59c0ae36@lxorguk.ukuu.org.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=amitoj1606@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®