mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Victor Dodon <printesoi@chromium.org>
Cc: linux-kernel@vger.kernel.org,
	Matthew Dharm <mdharm-usb@one-eyed-alien.net>,
	linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
	Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH v2] usb: storage: use usb_store_dbg instead of US_DEBUGPX
Date: Wed, 17 Feb 2016 11:10:59 -0800	[thread overview]
Message-ID: <20160217191059.GA27066@kroah.com> (raw)
In-Reply-To: <20160217184237.GA125188@printesoi1.mtv.corp.google.com>

On Wed, Feb 17, 2016 at 10:42:37AM -0800, Victor Dodon wrote:
> The US_DEBUGPX macro uses printk without specifying a kernel log level, so
> the default kernel log level is used, which may not match LOGLEVEL_DEBUG
> used in usb_stor_dbg. Remove the macro and use usb_store_dbg instead.
> 
> Signed-off-by: Victor Dodon <printesoi@chromium.org>
> --
> Changes in v2:
>   - Completely remove the macro instead of using printk_emit
>   - Change all uses of US_DEBUGPX to usb_stor_dbg

Great!  Now can you get rid of the horrid USB_DEBUG() macro as well?  I
don't think that's really needed anymore (the frecom driver's usage can
just be removed entirely).

thanks,

greg k-h

      reply	other threads:[~2016-02-17 19:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 18:42 Victor Dodon
2016-02-17 19:10 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160217191059.GA27066@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=gwendal@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mdharm-usb@one-eyed-alien.net \
    --cc=printesoi@chromium.org \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®