mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] irqchip: bcm2836: Drop extra memory barrier in SMP boot.
@ 2016-02-04 21:14 Eric Anholt
  2016-02-18  2:03 ` Jason Cooper
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Anholt @ 2016-02-04 21:14 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stephen Warren,
	Lee Jones, Thomas Gleixner, Jason Cooper, Marc Zyngier,
	Eric Anholt

The writel() immediately after this has a barrier, anyway.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/irqchip/irq-bcm2836.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c
index 963065a..b6e950d 100644
--- a/drivers/irqchip/irq-bcm2836.c
+++ b/drivers/irqchip/irq-bcm2836.c
@@ -229,7 +229,6 @@ int __init bcm2836_smp_boot_secondary(unsigned int cpu,
 	unsigned long secondary_startup_phys =
 		(unsigned long)virt_to_phys((void *)secondary_startup);
 
-	dsb();
 	writel(secondary_startup_phys,
 	       intc.base + LOCAL_MAILBOX3_SET0 + 16 * cpu);
 
-- 
2.7.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] irqchip: bcm2836: Drop extra memory barrier in SMP boot.
  2016-02-04 21:14 [PATCH] irqchip: bcm2836: Drop extra memory barrier in SMP boot Eric Anholt
@ 2016-02-18  2:03 ` Jason Cooper
  0 siblings, 0 replies; 2+ messages in thread
From: Jason Cooper @ 2016-02-18  2:03 UTC (permalink / raw)
  To: Eric Anholt
  Cc: Florian Fainelli, linux-rpi-kernel, linux-arm-kernel,
	linux-kernel, Stephen Warren, Lee Jones, Thomas Gleixner,
	Marc Zyngier

On Thu, Feb 04, 2016 at 01:14:28PM -0800, Eric Anholt wrote:
> The writel() immediately after this has a barrier, anyway.
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>  drivers/irqchip/irq-bcm2836.c | 1 -
>  1 file changed, 1 deletion(-)

Applied to irqchip/core

thx,

Jason.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-18  2:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-04 21:14 [PATCH] irqchip: bcm2836: Drop extra memory barrier in SMP boot Eric Anholt
2016-02-18  2:03 ` Jason Cooper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®