From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Matwey V. Kornilov" <matwey@sai.msu.ru>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Jiri Slaby" <jslaby@suse.com>,
"Peter Hurley" <peter@hurleysoftware.com>,
"One Thousand Gnomes" <gnomes@lxorguk.ukuu.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"Ильяс Гасанов" <torso.nafi@gmail.com>
Subject: Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()
Date: Thu, 18 Feb 2016 15:47:18 -0800 [thread overview]
Message-ID: <20160218234718.GB4517@kroah.com> (raw)
In-Reply-To: <CAJs94EbEOnQg0bQ8s-YD-AQfpKatovwyv81hJSbPpxy1RGhBBQ@mail.gmail.com>
On Thu, Feb 18, 2016 at 11:29:07PM +0300, Matwey V. Kornilov wrote:
> 2016-02-18 23:21 GMT+03:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
> > On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
> >> serial8250_em485_init() is supposed to be protected with
> >> p->port.lock spinlock.
> >> This may lead to issues when kmalloc sleeps, so it is better to use
> >> GFP_ATOMIC in this spinlocked context.
> >>
> >> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
> >> Reported-by: <torso.nafi@gmail.com>
> >
> > Hmm... Can't we put Cyrillic characters to tags as name of a person?
>
> I am afraid non-ASCII will break something eventually. I think it
> would be better to ask Ilias to put his name in proper latin
> transcription here.
Why, we accept non-ASCII names all the time, why would we not do so?
Please fix up and resend.
thansk,
greg k-h
next prev parent reply other threads:[~2016-02-18 23:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 18:47 Matwey V. Kornilov
2016-02-18 20:21 ` Andy Shevchenko
2016-02-18 20:29 ` Matwey V. Kornilov
2016-02-18 23:47 ` Greg Kroah-Hartman [this message]
2016-02-19 5:36 ` Matwey V. Kornilov
2016-02-19 11:53 ` Ильяс Гасанов
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218234718.GB4517@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=matwey@sai.msu.ru \
--cc=peter@hurleysoftware.com \
--cc=torso.nafi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®