* [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()
@ 2016-02-18 18:47 Matwey V. Kornilov
2016-02-18 20:21 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Matwey V. Kornilov @ 2016-02-18 18:47 UTC (permalink / raw)
To: gregkh, jslaby, peter, andy.shevchenko, gnomes
Cc: Matwey V. Kornilov, linux-kernel, linux-serial
serial8250_em485_init() is supposed to be protected with
p->port.lock spinlock.
This may lead to issues when kmalloc sleeps, so it is better to use
GFP_ATOMIC in this spinlocked context.
Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
Reported-by: <torso.nafi@gmail.com>
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
drivers/tty/serial/8250/8250_port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index c908b77..4d6deef 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -586,7 +586,7 @@ int serial8250_em485_init(struct uart_8250_port *p)
if (p->em485 != NULL)
return 0;
- p->em485 = kmalloc(sizeof(struct uart_8250_em485), GFP_KERNEL);
+ p->em485 = kmalloc(sizeof(struct uart_8250_em485), GFP_ATOMIC);
if (p->em485 == NULL)
return -ENOMEM;
--
2.7.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()
2016-02-18 18:47 [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() Matwey V. Kornilov
@ 2016-02-18 20:21 ` Andy Shevchenko
2016-02-18 20:29 ` Matwey V. Kornilov
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2016-02-18 20:21 UTC (permalink / raw)
To: Matwey V. Kornilov
Cc: Greg Kroah-Hartman, Jiri Slaby, Peter Hurley,
One Thousand Gnomes, linux-kernel, linux-serial
On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
> serial8250_em485_init() is supposed to be protected with
> p->port.lock spinlock.
> This may lead to issues when kmalloc sleeps, so it is better to use
> GFP_ATOMIC in this spinlocked context.
>
> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
> Reported-by: <torso.nafi@gmail.com>
Hmm... Can't we put Cyrillic characters to tags as name of a person?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()
2016-02-18 20:21 ` Andy Shevchenko
@ 2016-02-18 20:29 ` Matwey V. Kornilov
2016-02-18 23:47 ` Greg Kroah-Hartman
2016-02-19 11:53 ` Ильяс Гасанов
0 siblings, 2 replies; 6+ messages in thread
From: Matwey V. Kornilov @ 2016-02-18 20:29 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Greg Kroah-Hartman, Jiri Slaby, Peter Hurley,
One Thousand Gnomes, linux-kernel, linux-serial,
Ильяс
Гасанов
2016-02-18 23:21 GMT+03:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
> On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
>> serial8250_em485_init() is supposed to be protected with
>> p->port.lock spinlock.
>> This may lead to issues when kmalloc sleeps, so it is better to use
>> GFP_ATOMIC in this spinlocked context.
>>
>> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
>> Reported-by: <torso.nafi@gmail.com>
>
> Hmm... Can't we put Cyrillic characters to tags as name of a person?
I am afraid non-ASCII will break something eventually. I think it
would be better to ask Ilias to put his name in proper latin
transcription here.
> --
> With Best Regards,
> Andy Shevchenko
>
--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119991, Moscow, Universitetsky pr-k 13, +7 (495) 9392382
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()
2016-02-18 20:29 ` Matwey V. Kornilov
@ 2016-02-18 23:47 ` Greg Kroah-Hartman
2016-02-19 5:36 ` Matwey V. Kornilov
2016-02-19 11:53 ` Ильяс Гасанов
1 sibling, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2016-02-18 23:47 UTC (permalink / raw)
To: Matwey V. Kornilov
Cc: Andy Shevchenko, Jiri Slaby, Peter Hurley, One Thousand Gnomes,
linux-kernel, linux-serial,
Ильяс
Гасанов
On Thu, Feb 18, 2016 at 11:29:07PM +0300, Matwey V. Kornilov wrote:
> 2016-02-18 23:21 GMT+03:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
> > On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
> >> serial8250_em485_init() is supposed to be protected with
> >> p->port.lock spinlock.
> >> This may lead to issues when kmalloc sleeps, so it is better to use
> >> GFP_ATOMIC in this spinlocked context.
> >>
> >> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
> >> Reported-by: <torso.nafi@gmail.com>
> >
> > Hmm... Can't we put Cyrillic characters to tags as name of a person?
>
> I am afraid non-ASCII will break something eventually. I think it
> would be better to ask Ilias to put his name in proper latin
> transcription here.
Why, we accept non-ASCII names all the time, why would we not do so?
Please fix up and resend.
thansk,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()
2016-02-18 23:47 ` Greg Kroah-Hartman
@ 2016-02-19 5:36 ` Matwey V. Kornilov
0 siblings, 0 replies; 6+ messages in thread
From: Matwey V. Kornilov @ 2016-02-19 5:36 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Andy Shevchenko, Jiri Slaby, Peter Hurley, One Thousand Gnomes,
linux-kernel, linux-serial,
Ильяс
Гасанов
2016-02-19 2:47 GMT+03:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Thu, Feb 18, 2016 at 11:29:07PM +0300, Matwey V. Kornilov wrote:
>> 2016-02-18 23:21 GMT+03:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
>> > On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
>> >> serial8250_em485_init() is supposed to be protected with
>> >> p->port.lock spinlock.
>> >> This may lead to issues when kmalloc sleeps, so it is better to use
>> >> GFP_ATOMIC in this spinlocked context.
>> >>
>> >> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
>> >> Reported-by: <torso.nafi@gmail.com>
>> >
>> > Hmm... Can't we put Cyrillic characters to tags as name of a person?
>>
>> I am afraid non-ASCII will break something eventually. I think it
>> would be better to ask Ilias to put his name in proper latin
>> transcription here.
>
> Why, we accept non-ASCII names all the time, why would we not do so?
>
> Please fix up and resend.
Sure, I've just sent v2.
I am used that non-ASCIIs break things, as they did it 20 years ago,
as they do it in 2016. GhostView stole all my Cyrillic characters from
PDF when I tried to embed fonts two days ago .
>
> thansk,
>
> greg k-h
>
--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119991, Moscow, Universitetsky pr-k 13, +7 (495) 9392382
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()
2016-02-18 20:29 ` Matwey V. Kornilov
2016-02-18 23:47 ` Greg Kroah-Hartman
@ 2016-02-19 11:53 ` Ильяс Гасанов
1 sibling, 0 replies; 6+ messages in thread
From: Ильяс Гасанов @ 2016-02-19 11:53 UTC (permalink / raw)
To: Matwey V. Kornilov
Cc: Andy Shevchenko, Greg Kroah-Hartman, Jiri Slaby, Peter Hurley,
One Thousand Gnomes, linux-kernel, linux-serial
Hello,
2016-02-18 23:29 GMT+03:00 Matwey V. Kornilov <matwey@sai.msu.ru>:
> I am afraid non-ASCII will break something eventually. I think it
> would be better to ask Ilias to put his name in proper latin
> transcription here.
The most proper transcription I think is Ilyas Gasanov.
Regards,
Ilyas G.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-19 11:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-18 18:47 [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() Matwey V. Kornilov
2016-02-18 20:21 ` Andy Shevchenko
2016-02-18 20:29 ` Matwey V. Kornilov
2016-02-18 23:47 ` Greg Kroah-Hartman
2016-02-19 5:36 ` Matwey V. Kornilov
2016-02-19 11:53 ` Ильяс Гасанов
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®