From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
eranian@google.com, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/6] perf, tools, stat: Support metrics in --per-core/socket mode
Date: Sun, 21 Feb 2016 18:15:35 +0100 [thread overview]
Message-ID: <20160221171535.GC10701@krava.homerouter.cpe> (raw)
In-Reply-To: <1455749045-18098-4-git-send-email-andi@firstfloor.org>
On Wed, Feb 17, 2016 at 02:44:02PM -0800, Andi Kleen wrote:
SNIP
> @@ -892,7 +908,10 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval,
> struct perf_stat_output_ctx out;
> struct outstate os = {
> .fh = stat_config.output,
> - .prefix = prefix ? prefix : ""
> + .prefix = prefix ? prefix : "",
> + .id = id,
> + .nr = nr,
> + .evsel = counter,
> };
> print_metric_t pm = print_metric_std;
> void (*nl)(void *);
> @@ -962,15 +981,38 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval,
>
> perf_stat__print_shadow_stats(counter, uval,
> stat_config.aggr_mode == AGGR_GLOBAL ? 0 :
> - cpu_map__id_to_cpu(id),
> + first_shadow_cpu(counter, id),
hum, IIUC you need to handle AGGR_NONE in here as well?
thanks,
jirka
next prev parent reply other threads:[~2016-02-21 17:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 22:43 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-02-17 22:44 ` [PATCH 1/6] perf, tools, stat: Handled scaled == -1 case for counters Andi Kleen
2016-02-20 11:35 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-02-17 22:44 ` [PATCH 2/6] perf, tools, stat: Implement CSV metrics output Andi Kleen
2016-02-18 17:00 ` Arnaldo Carvalho de Melo
2016-02-18 17:39 ` Andi Kleen
2016-02-21 16:39 ` Jiri Olsa
2016-02-22 16:26 ` Andi Kleen
2016-02-21 16:39 ` Jiri Olsa
2016-02-17 22:44 ` [PATCH 3/6] perf, tools, stat: Support metrics in --per-core/socket mode Andi Kleen
2016-02-21 17:15 ` Jiri Olsa [this message]
2016-02-22 16:52 ` Andi Kleen
2016-02-23 7:37 ` Jiri Olsa
2016-02-21 17:18 ` Jiri Olsa
2016-02-21 17:22 ` Jiri Olsa
2016-02-26 23:53 ` Andi Kleen
2016-02-17 22:44 ` [PATCH 4/6] perf, tools, stat: Document CSV format in manpage Andi Kleen
2016-02-17 22:44 ` [PATCH 5/6] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-02-17 22:44 ` [PATCH 6/6] perf, tools, stat: Add --metric-only support for -A Andi Kleen
2016-02-27 0:27 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-02-27 0:27 ` [PATCH 3/6] perf, tools, stat: Support metrics in --per-core/socket mode Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160221171535.GC10701@krava.homerouter.cpe \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®