From: Liviu Dudau <Liviu.Dudau@arm.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Mark Yao" <mark.yao@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"Eric Anholt" <eric@anholt.net>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
LAKML <linux-arm-kernel@lists.infradead.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.
Date: Mon, 22 Feb 2016 15:57:40 +0000 [thread overview]
Message-ID: <20160222155740.GU1123@e106497-lin.cambridge.arm.com> (raw)
In-Reply-To: <20160222155128.GE19428@n2100.arm.linux.org.uk>
On Mon, Feb 22, 2016 at 03:51:29PM +0000, Russell King - ARM Linux wrote:
> On Mon, Feb 22, 2016 at 11:51:47AM +0000, Liviu Dudau wrote:
> > On Fri, Nov 20, 2015 at 02:22:04PM +0000, Liviu Dudau wrote:
> > > Rockchip DRM driver cannot use the same compare_of() function to
> > > match ports and remote ports (aka encoders) as their OF sub-trees
> > > look different. Add a second compare function to be used when encoders
> > > are added to the component framework and patch the existing users of
> > > the function accordingly.
> > >
> > > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> >
> > Russell,
> >
> > Resurecting this old patch from around Christmas time (bad time for patch
> > review).
> >
> > Are you happy enough with this version to re-issue the Ack or do you think
> > I still need to work on it?
>
> What I'd like to see is the patch reworked, because:
>
> > > + component_match_add(dev, &match, compare_port, port);
> > > + /*
> > > + * component_match_add keeps a reference to the port
> > > + * variable, so we need to keep the reference count
> > > + * increment from of_parse_phandle()
> > > + */
> ...
> > > + component_match_add(dev, &match, compare_encoder, remote);
> > > + /*
> > > + * component_match_add keeps a reference to the port
> > > + * variable, so we need to keep the reference count
> > > + * increment from of_graph_get_remote_port_parent()
> > > + */
>
> This problem no longer exists.
Fair enough, I will send a v3 version.
Thanks,
Liviu
>
> --
> RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
next prev parent reply other threads:[~2016-02-22 15:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 14:22 [PATCH v2 0/2] Improve drm_of_component_probe() and move rockchip to use it Liviu Dudau
2015-11-20 14:22 ` [PATCH v2 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports Liviu Dudau
2016-02-22 11:51 ` Liviu Dudau
2016-02-22 15:51 ` Russell King - ARM Linux
2016-02-22 15:57 ` Liviu Dudau [this message]
2015-11-20 14:22 ` [PATCH v2 2/2] drm/rockchip: Convert the probe function to the generic drm_of_component_probe() Liviu Dudau
2015-11-23 9:39 ` Mark yao
2015-11-23 23:20 ` [PATCH v2 0/2] Improve drm_of_component_probe() and move rockchip to use it Heiko Stübner
2015-12-12 13:29 ` Heiko Stübner
2015-12-22 17:38 ` Liviu Dudau
2015-12-23 1:33 ` Dave Airlie
2015-12-23 9:39 ` Jean-Francois Moine
2015-12-23 10:05 ` Liviu Dudau
2015-12-23 17:20 ` Jean-Francois Moine
2015-12-23 18:59 ` Russell King - ARM Linux
2015-12-24 8:15 ` Jean-Francois Moine
2015-12-24 10:52 ` Russell King - ARM Linux
2015-12-24 12:27 ` Jean-Francois Moine
2015-12-24 12:36 ` Russell King - ARM Linux
2015-12-25 9:38 ` Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222155740.GU1123@e106497-lin.cambridge.arm.com \
--to=liviu.dudau@arm.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.yao@rock-chips.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®