From: Peter Zijlstra <peterz@infradead.org>
To: Pratyush Anand <panand@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
mingo@kernel.org, alexander.shishkin@linux.intel.com,
eranian@google.com, linux-kernel@vger.kernel.org,
vince@deater.net, dvyukov@google.com, andi@firstfloor.org,
sasha.levin@oracle.com, oleg@redhat.com
Subject: Re: [RFC][PATCH 4/7] perf: Fix scaling vs enable_on_exec
Date: Wed, 24 Feb 2016 15:02:39 +0100 [thread overview]
Message-ID: <20160224140239.GT6375@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160224115351.GS6375@twins.programming.kicks-ass.net>
On Wed, Feb 24, 2016 at 12:53:51PM +0100, Peter Zijlstra wrote:
> On Tue, Feb 23, 2016 at 06:47:41PM +0100, Peter Zijlstra wrote:
> > On Tue, Feb 23, 2016 at 10:05:50PM +0530, Pratyush Anand wrote:
> > > Its better with this patch, still count is 1 more in case of higher probe hits (
> > > like 65535 times).
> >
> > Ah, ok, I'll go try again.
>
> OK, so the below seems to cure this for me, but now I'm hurting my head
> to make the same true for perf_install_in_context(), because 'tricky' :/
>
FWIW, it would be nice to have a similar test for:
attr = {
.disabled = true;
}
sys_perf_event_open(&attr, .pid = self);
if (attr.disabled)
ioctl(ENABLE);
/* generate N events */
ioctl(DISABLE);
read();
/* print event cnt and scale factors */
and one that has .disabled = false.
next prev parent reply other threads:[~2016-02-24 14:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 14:37 [RFC][PATCH 0/7] perf: more fuzzer inspired patches Peter Zijlstra
2016-02-19 14:37 ` [RFC][PATCH 1/7] perf: Close install vs exit race Peter Zijlstra
2016-02-19 14:37 ` [RFC][PATCH 2/7] perf: Do not double free Peter Zijlstra
2016-02-19 14:37 ` [RFC][PATCH 3/7] perf: Allow perf_release() with !event->ctx Peter Zijlstra
2016-02-19 14:37 ` [RFC][PATCH 4/7] perf: Fix scaling vs enable_on_exec Peter Zijlstra
2016-02-23 15:27 ` Peter Zijlstra
2016-02-23 15:48 ` Jiri Olsa
2016-02-23 16:35 ` Pratyush Anand
2016-02-23 17:47 ` Peter Zijlstra
2016-02-24 11:53 ` Peter Zijlstra
2016-02-24 14:02 ` Peter Zijlstra [this message]
2016-02-24 16:02 ` Peter Zijlstra
2016-02-25 4:07 ` Pratyush Anand
2016-02-23 21:44 ` Jiri Olsa
2016-02-26 2:25 ` Oleg Nesterov
2016-02-19 14:37 ` [RFC][PATCH 5/7] perf: Fix cloning Peter Zijlstra
2016-02-19 14:37 ` [RFC][PATCH 6/7] perf: Fix race between event install and jump_labels Peter Zijlstra
2016-02-19 14:37 ` [RFC][PATCH 7/7] perf: Cure event->pending_disable race Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224140239.GT6375@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dvyukov@google.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=panand@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome