From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
live-patching@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
Namhyung Kim <namhyung@gmail.com>,
Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
Chris J Arges <chris.j.arges@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jiri Slaby <jslaby@suse.cz>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH v17 4/9] x86/objtool: Add STACK_FRAME_NON_STANDARD macro
Date: Thu, 25 Feb 2016 14:26:50 -0600 [thread overview]
Message-ID: <20160225202650.GB5763@treble.redhat.com> (raw)
In-Reply-To: <20160225075149.GA2354@gmail.com>
On Thu, Feb 25, 2016 at 08:51:49AM +0100, Ingo Molnar wrote:
> > diff --git a/include/linux/objtool.h b/include/linux/objtool.h
> > new file mode 100644
> > index 0000000..cce9d67
> > --- /dev/null
> > +++ b/include/linux/objtool.h
>
> So I think this should really be in asm/frame.h, not in an objtool specific
> header.
I agree that it shouldn't be in an objtool-specific header, but
asm/frame.h wouldn't work unless we added that file to all the arches.
And the macro's functionality is arch-independent anyway. So I'm
renaming the file to include/linux/frame.h.
--
Josh
next prev parent reply other threads:[~2016-02-25 20:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 16:36 [PATCH v17 0/9] Compile-time stack metadata validation Josh Poimboeuf
2016-02-24 16:36 ` [PATCH v17 1/9] x86/objtool: " Josh Poimboeuf
2016-02-24 16:36 ` [PATCH v17 2/9] x86/objtool: Add CONFIG_STACK_VALIDATION option Josh Poimboeuf
2016-02-24 16:36 ` [PATCH v17 3/9] x86/objtool: Enable objtool on x86_64 Josh Poimboeuf
2016-02-24 16:36 ` [PATCH v17 4/9] x86/objtool: Add STACK_FRAME_NON_STANDARD macro Josh Poimboeuf
2016-02-25 7:51 ` Ingo Molnar
2016-02-25 20:26 ` Josh Poimboeuf [this message]
2016-02-24 16:36 ` [PATCH v17 5/9] x86/objtool: Add directory and file whitelists Josh Poimboeuf
2016-02-24 16:36 ` [PATCH v17 6/9] x86/xen: Add xen_cpuid() to objtool whitelist Josh Poimboeuf
2016-02-25 7:54 ` Ingo Molnar
2016-02-24 16:36 ` [PATCH v17 7/9] bpf: Add __bpf_prog_run() " Josh Poimboeuf
2016-02-24 16:36 ` [PATCH v17 8/9] sched: Add __schedule() " Josh Poimboeuf
2016-02-24 16:36 ` [PATCH v17 9/9] x86/kprobes: Add kretprobe_trampoline() " Josh Poimboeuf
2016-02-25 8:02 ` [PATCH v17 0/9] Compile-time stack metadata validation Ingo Molnar
2016-02-25 17:04 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225202650.GB5763@treble.redhat.com \
--to=jpoimboe@redhat.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bernd@petrovitsch.priv.at \
--cc=bp@alien8.de \
--cc=chris.j.arges@canonical.com \
--cc=hpa@zytor.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=namhyung@gmail.com \
--cc=palves@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome