From: Andy Gross <andy.gross@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: smp2p: Use memset_io to zero out new entries
Date: Thu, 25 Feb 2016 16:02:24 -0600 [thread overview]
Message-ID: <20160225220224.GA9986@hector.attlocal.net> (raw)
In-Reply-To: <1456417057-17591-1-git-send-email-bjorn.andersson@linaro.org>
On Thu, Feb 25, 2016 at 08:17:37AM -0800, Bjorn Andersson wrote:
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/soc/qcom/smp2p.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c
> index f1eed7f9dd67..61df598444e6 100644
> --- a/drivers/soc/qcom/smp2p.c
> +++ b/drivers/soc/qcom/smp2p.c
> @@ -379,7 +379,7 @@ static int qcom_smp2p_alloc_outbound_item(struct qcom_smp2p *smp2p)
> return PTR_ERR(out);
> }
>
> - memset(out, 0, sizeof(*out));
> + memset_io(out, 0, sizeof(*out));
> out->magic = SMP2P_MAGIC;
> out->local_pid = smp2p->local_pid;
> out->remote_pid = smp2p->remote_pid;
Good catch. I'll add this fix for the pull.
next prev parent reply other threads:[~2016-02-25 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 16:17 Bjorn Andersson
2016-02-25 22:02 ` Andy Gross [this message]
2016-03-01 17:10 ` Paul Walmsley
2016-03-01 17:27 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225220224.GA9986@hector.attlocal.net \
--to=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome