From: Jiri Olsa <jolsa@redhat.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kernel@vger.kernel.org,
Aaro Koskinen <aaro.koskinen@nokia.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Lukas Wunner <lukas@wunner.de>, Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH] tools build: use .s extension for preprocessed assembler code
Date: Tue, 1 Mar 2016 14:06:31 +0100 [thread overview]
Message-ID: <20160301130631.GB26168@krava.redhat.com> (raw)
In-Reply-To: <1454263140-19670-1-git-send-email-yamada.masahiro@socionext.com>
On Mon, Feb 01, 2016 at 02:59:00AM +0900, Masahiro Yamada wrote:
> The "man gcc" says .i extension represents the file is C source code
> that should not be preprocessed. Here, .s should be used.
>
> For clarification,
> .c ---(preprocess)---> .i
> .S ---(preprocess)---> .s
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> tools/build/Makefile.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> index 4a96473..ee566e8 100644
> --- a/tools/build/Makefile.build
> +++ b/tools/build/Makefile.build
> @@ -85,7 +85,7 @@ $(OUTPUT)%.i: %.c FORCE
> $(call rule_mkdir)
> $(call if_changed_dep,cc_i_c)
>
> -$(OUTPUT)%.i: %.S FORCE
> +$(OUTPUT)%.s: %.S FORCE
> $(call rule_mkdir)
> $(call if_changed_dep,cc_i_c)
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-03-01 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 17:59 Masahiro Yamada
2016-03-01 5:31 ` Masahiro Yamada
2016-03-01 13:20 ` Arnaldo Carvalho de Melo
2016-03-01 13:06 ` Jiri Olsa [this message]
2016-03-05 8:18 ` [tip:perf/core] tools build: Use " tip-bot for Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301130631.GB26168@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=aaro.koskinen@nokia.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome