From: Mark Brown <broonie@kernel.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Applied "regulator: max8973: add support for junction thermal warning" to the regulator tree
Date: Sun, 6 Mar 2016 18:35:50 +0700 [thread overview]
Message-ID: <20160306113550.GM18327@sirena.org.uk> (raw)
In-Reply-To: <56DBE099.9080408@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
On Sun, Mar 06, 2016 at 01:17:37PM +0530, Laxman Dewangan wrote:
> Here driver is built in binary and THERMAL is the loadable module.
> Do we really have THERMAL as module i.e. basic framework?
If randconfig can generate it it's valid.
> -#ifdef CONFIG_THERMAL_OF
> +#ifdef CONFIG_THERMAL
> static int max8973_thermal_read_temp(void *data, int *temp)
> {
> struct max8973_chip *mchip = data;
That looks like a hack that might break, I'd not expect it to help here
and probably has some other config that can generate issues. What I
think should be happening here is something like
depends on THERMAL_OF if THERMAL_OF
or similar (ie, there's a direct dependency once the config is enabled).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-06 11:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-05 12:25 Mark Brown
2016-03-06 2:35 ` Mark Brown
2016-03-06 7:47 ` Laxman Dewangan
2016-03-06 11:35 ` Mark Brown [this message]
2016-03-07 6:36 ` Laxman Dewangan
2016-03-07 7:44 ` Mark Brown
2016-03-07 10:54 ` Laxman Dewangan
2016-03-08 2:22 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2016-04-13 9:59 [PATCH V3 2/2] regulator: max8973: add support for junction thermal warning Laxman Dewangan
2016-04-13 16:21 ` Applied "regulator: max8973: add support for junction thermal warning" to the regulator tree Mark Brown
2016-04-13 17:01 ` Laxman Dewangan
2016-01-06 16:07 [PATCH V2] regulator: max8973: add support for junction thermal warning Laxman Dewangan
2016-01-06 18:12 ` Applied "regulator: max8973: add support for junction thermal warning" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306113550.GM18327@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®