From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Miroslav Benes <mbenes@suse.cz>,
sjenning@redhat.com, vojtech@suse.com, pmladek@suse.cz,
mpe@ellerman.id.au, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] klp: remove superfluous errors in asm/livepatch.h
Date: Sun, 6 Mar 2016 22:10:41 -0600 [thread overview]
Message-ID: <20160307041041.GB11604@treble.hsd1.ky.comcast.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1603062211300.3656@cbobk.fhfr.pm>
On Sun, Mar 06, 2016 at 10:13:56PM +0100, Jiri Kosina wrote:
> On Fri, 4 Mar 2016, Josh Poimboeuf wrote:
>
> > > There is an #error in asm/livepatch.h for both x86 and s390 in
> > > !CONFIG_LIVEPATCH cases. It does not make much sense as pointed out by
> > > Michael Ellerman. One can happily include asm/livepatch.h with
> > > CONFIG_LIVEPATCH. Remove it as useless.
> > >
> > > Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> > > Signed-off-by: Miroslav Benes <mbenes@suse.cz>
> >
> > Looks fine to me.
>
> Thanks. I consider this to be your Ack then :) (if you disagree, please
> shout loudly).
:-)
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
> > While we're at it, do we even need the '#ifdef CONFIG_LIVEPATCH' in
> > these files? And in include/linux/livepatch.h?
>
> You are right, this seems indeed completely unnecessary. I'll remove it
> for 4.6 as well, if noone has any objections.
--
Josh
next prev parent reply other threads:[~2016-03-07 4:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 9:53 Miroslav Benes
2016-03-04 21:45 ` Josh Poimboeuf
2016-03-06 21:13 ` Jiri Kosina
2016-03-07 4:10 ` Josh Poimboeuf [this message]
2016-03-08 21:28 ` Jessica Yu
2016-03-09 10:06 ` Petr Mladek
2016-03-09 10:39 ` Jiri Kosina
2016-03-09 16:11 ` Josh Poimboeuf
2016-03-15 11:37 ` [PATCH] " Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307041041.GB11604@treble.hsd1.ky.comcast.net \
--to=jpoimboe@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mpe@ellerman.id.au \
--cc=pmladek@suse.cz \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®