From: Peter Zijlstra <peterz@infradead.org>
To: James Morse <james.morse@arm.com>
Cc: mingo@kernel.org, alexander.shishkin@linux.intel.com,
eranian@google.com, linux-kernel@vger.kernel.org,
vince@deater.net, dvyukov@google.com, andi@firstfloor.org,
jolsa@redhat.com, Mark Rutland <mark.rutland@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
wangxg.fnst@cn.fujitsu.com
Subject: Re: [RFC][PATCH 07/12] perf: Simplify/fix perf_event_enable() event scheduling
Date: Tue, 8 Mar 2016 11:26:03 +0100 [thread overview]
Message-ID: <20160308102603.GX6344@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <56DEA3A1.3080206@arm.com>
On Tue, Mar 08, 2016 at 10:04:17AM +0000, James Morse wrote:
> [0]
> https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/perf_event_open/perf_event_open02.c
I so hate LTP, you can't compile the test cases in isolate and running
'make' doesn't work.
> [2]
> ----------------------------------------
> x86_64, v4.2
> nanook@trouble-every-day:~$ ./perf_event_open02 -v
> at iteration:0 value:3001278671 time_enabled:378865967 time_running:378865967
> at iteration:1 value:3001294516 time_enabled:379206798 time_running:379206798
> at iteration:2 value:3001304264 time_enabled:379741658 time_running:379741658
> at iteration:3 value:2247456463 time_enabled:381782350 time_running:285882994
> perf_event_open02 0 TINFO : overall task clock: 382444297
> perf_event_open02 0 TINFO : hw sum: 9004576323, task clock sum: 1146042829
> hw counters: 1276985606 1284698955 1291658694 1294253771 1293189575 1285360592
> 1278429130
> task clock counters: 162510606 163544930 164439727 164730880 164600624 163538072
> 162677990
> perf_event_open02 0 TINFO : ratio: 3.00
> perf_event_open02 1 TPASS : test passed
> ----------------------------------------
> x86_64, v4.5-rc5:
> nanook@trouble-every-day:~$ ./perf_event_open02 -v
> at iteration:0 value:3001332678 time_enabled:379409484 time_running:379408991
> perf_event_open02 0 TINFO : overall task clock: 381025905
> perf_event_open02 0 TINFO : hw sum: 9004621962, task clock sum: 1142038427
> hw counters: 2249100352 2254366204 2252915996 2248239410
> task clock counters: 285302769 285853299 285787328 285095031
> perf_event_open02 0 TINFO : ratio: 3.00
> perf_event_open02 1 TFAIL : perf_event_open02.c:333: test failed (ratio
> was greater than )
> ----------------------------------------
Its unfortunate the test doesn't actually tells what it was expecting.
It fails to print 'nhw'.
In any case, please try -rc6, which includes:
a096309bc467 perf: Fix scaling vs. perf_install_in_context()
bd2afa49d194 perf: Fix scaling vs. perf_event_enable()
7fce250915ef perf: Fix scaling vs. perf_event_enable_on_exec()
3cbaa5906967 perf: Fix ctx time tracking by introducing EVENT_TIME
Which might fix this. I gave up after a few minutes trying to make LTP
work.
next prev parent reply other threads:[~2016-03-08 10:26 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 16:24 [RFC][PATCH 00/12] various perf fixes Peter Zijlstra
2016-01-11 16:24 ` [RFC][PATCH 01/12] perf: Add lockdep assertions Peter Zijlstra
2016-01-11 16:25 ` [RFC][PATCH 02/12] perf: Fix cgroup event scheduling Peter Zijlstra
2016-01-11 19:43 ` Stephane Eranian
2016-01-11 22:03 ` Peter Zijlstra
2016-01-11 16:25 ` [RFC][PATCH 03/12] perf: Fix cgroup scheduling in enable_on_exec Peter Zijlstra
2016-01-11 16:25 ` [RFC][PATCH 04/12] perf: Remove stale comment Peter Zijlstra
2016-01-11 16:25 ` [RFC][PATCH 05/12] perf: Fix enable_on_exec event scheduling Peter Zijlstra
2016-01-11 16:25 ` [RFC][PATCH 06/12] perf: Use task_ctx_sched_out() Peter Zijlstra
2016-01-11 16:25 ` [RFC][PATCH 07/12] perf: Simplify/fix perf_event_enable() event scheduling Peter Zijlstra
2016-03-08 10:04 ` James Morse
2016-03-08 10:26 ` Peter Zijlstra [this message]
2016-03-08 10:42 ` James Morse
2016-03-08 11:29 ` Peter Zijlstra
2016-01-11 16:25 ` [RFC][PATCH 08/12] perf: Optimize perf_sched_events usage Peter Zijlstra
2016-01-11 16:25 ` [RFC][PATCH 09/12] perf: Make ctx->is_active and cpuctx->task_ctx consistent Peter Zijlstra
2016-01-11 16:25 ` [RFC][PATCH 10/12] perf: Fix task context scheduling Peter Zijlstra
2016-01-11 16:25 ` [RFC][PATCH 11/12] perf: Specialize perf_event_exit_task() Peter Zijlstra
2016-01-11 16:25 ` [RFC][PATCH 12/12] perf: Collapse and fix event_function_call() users Peter Zijlstra
2016-01-13 10:50 ` Peter Zijlstra
2016-01-13 13:46 ` Alexander Shishkin
2016-01-13 17:30 ` Peter Zijlstra
2016-01-13 15:00 ` Alexander Shishkin
2016-01-13 15:38 ` Alexander Shishkin
2016-01-13 18:10 ` Peter Zijlstra
2016-01-13 20:44 ` Peter Zijlstra
2016-01-14 10:44 ` Peter Zijlstra
2016-01-14 16:30 ` Peter Zijlstra
2016-02-17 22:38 ` Sasha Levin
2016-02-18 7:46 ` Peter Zijlstra
2016-02-18 12:37 ` Peter Zijlstra
2016-01-11 18:44 ` [RFC][PATCH 00/12] various perf fixes Dmitry Vyukov
2016-01-11 19:56 ` Andi Kleen
2016-01-11 22:00 ` Peter Zijlstra
2016-01-12 9:59 ` Ingo Molnar
2016-01-12 10:11 ` Ingo Molnar
2016-01-12 10:57 ` Dmitry Vyukov
2016-01-12 11:00 ` Dmitry Vyukov
2016-01-12 11:01 ` Dmitry Vyukov
2016-01-12 11:26 ` Dmitry Vyukov
2016-01-12 11:35 ` Dmitry Vyukov
2016-01-12 12:01 ` Peter Zijlstra
2016-01-13 15:18 ` Alexander Shishkin
2016-01-13 15:22 ` Dmitry Vyukov
2016-01-13 15:35 ` Alexander Shishkin
2016-01-14 9:35 ` Peter Zijlstra
2016-01-14 10:05 ` Dmitry Vyukov
2016-02-15 15:04 ` Dmitry Vyukov
2016-02-15 15:38 ` Peter Zijlstra
2016-02-15 15:47 ` Dmitry Vyukov
2016-02-15 16:01 ` Vince Weaver
2016-02-15 16:17 ` Peter Zijlstra
2016-02-15 16:29 ` Dmitry Vyukov
2016-02-15 16:29 ` Peter Zijlstra
2016-02-15 16:35 ` Dmitry Vyukov
2016-02-15 16:38 ` Dmitry Vyukov
2016-02-15 16:52 ` Peter Zijlstra
2016-02-15 17:04 ` Dmitry Vyukov
2016-02-15 17:07 ` Peter Zijlstra
2016-02-15 17:45 ` Dmitry Vyukov
2016-02-15 18:01 ` Peter Zijlstra
2016-02-15 18:33 ` Dmitry Vyukov
2016-02-15 16:41 ` Peter Zijlstra
2016-02-15 16:54 ` Dmitry Vyukov
2016-02-15 16:59 ` Peter Zijlstra
2016-01-12 13:13 ` Peter Zijlstra
2016-01-12 13:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308102603.GX6344@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Will.Deacon@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dvyukov@google.com \
--cc=eranian@google.com \
--cc=james.morse@arm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=vince@deater.net \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome