From: Mark Brown <broonie@kernel.org>
To: Mihai Mihalache <mihai.d.mihalache@intel.com>
Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
hans.holmberg@intel.com, yousaf.kaukab@intel.com
Subject: Re: [PATCH] regulator: gpio: check return value of of_get_named_gpio
Date: Thu, 10 Mar 2016 10:10:12 +0700 [thread overview]
Message-ID: <20160310031012.GH3898@sirena.org.uk> (raw)
In-Reply-To: <1457531442-4695-1-git-send-email-mihai.d.mihalache@intel.com>
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
On Wed, Mar 09, 2016 at 05:50:42AM -0800, Mihai Mihalache wrote:
> config->enable_gpio = of_get_named_gpio(np, "enable-gpio", 0);
> + if(IS_ERR_VALUE(config->enable_gpio))
> + return ERR_PTR(config->enable_gpio);
Please follow the kernel coding style - if(.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-03-10 3:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 13:50 Mihai Mihalache
2016-03-10 3:10 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310031012.GH3898@sirena.org.uk \
--to=broonie@kernel.org \
--cc=hans.holmberg@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.d.mihalache@intel.com \
--cc=yousaf.kaukab@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®