From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [RFC PATCH 1/3] siox: new driver/bus framework for Eckelmann SIOX
Date: Fri, 11 Mar 2016 14:20:39 -0800 [thread overview]
Message-ID: <20160311222039.GC3912@kroah.com> (raw)
In-Reply-To: <1457733134-25090-2-git-send-email-u.kleine-koenig@pengutronix.de>
On Fri, Mar 11, 2016 at 10:52:12PM +0100, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/siox/Kconfig | 2 +
> drivers/siox/Makefile | 1 +
> drivers/siox/siox-core.c | 572 +++++++++++++++++++++++++++++++++++++++++++++++
> drivers/siox/siox.h | 48 ++++
> include/linux/siox.h | 53 +++++
> 7 files changed, 679 insertions(+)
> create mode 100644 drivers/siox/Kconfig
> create mode 100644 drivers/siox/Makefile
> create mode 100644 drivers/siox/siox-core.c
> create mode 100644 drivers/siox/siox.h
> create mode 100644 include/linux/siox.h
What's the relationship between your "master" and "regular" devices
here? I think that's getting things confused, you are unregistering
your 'master' yet the children it controls don't go away because you
never unregister them. You need to fix this heirachy up a bit, and
maybe just drop the 'master' logic?
thanks,
greg k-h
next prev parent reply other threads:[~2016-03-11 22:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 21:52 [RFC PATCH 0/3] new bus type siox Uwe Kleine-König
2016-03-11 21:52 ` [RFC PATCH 1/3] siox: new driver/bus framework for Eckelmann SIOX Uwe Kleine-König
2016-03-11 22:20 ` Greg Kroah-Hartman [this message]
2016-03-12 13:43 ` Uwe Kleine-König
2016-03-13 3:42 ` Greg Kroah-Hartman
2016-03-11 21:52 ` [RFC PATCH 2/3] siox: add gpio bus driver Uwe Kleine-König
2016-03-11 21:52 ` [RFC PATCH 3/3] gpio: new driver to work with a 8x12 siox Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311222039.GC3912@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®