From: Johannes Thumshirn <jthumshirn@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: axboe@fb.com,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org, hch@lst.de,
Keith Busch <keith.busch@intel.com>,
linux-block@vger.kernel.org,
Ross Zwisler <ross.zwisler@linux.intel.com>,
David Woodhouse <dwmw2@infradead.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 2/3] block: convert to device_add_disk()
Date: Mon, 14 Mar 2016 09:15:00 +0100 [thread overview]
Message-ID: <20160314081500.GQ16624@c203.arch.suse.de> (raw)
In-Reply-To: <20160311154738.24401.867.stgit@dwillia2-desk3.jf.intel.com>
On Fri, Mar 11, 2016 at 07:47:38AM -0800, Dan Williams wrote:
> For block drivers that specify a parent device, convert them to use
> device_add_disk().
>
> This conversion was done with the following semantic patch:
>
> @@
> struct gendisk *disk;
> expression E;
> @@
>
> - disk->driverfs_dev = E;
> ...
> - add_disk(disk);
> + device_add_disk(E, disk);
>
> @@
> struct gendisk *disk;
> expression E1, E2;
> @@
>
> - disk->driverfs_dev = E1;
> ...
> E2 = disk;
> ...
> - add_disk(E2);
> + device_add_disk(E1, E2);
>
> ...plus some manual fixups for a few missed conversions.
>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Keith Busch <keith.busch@intel.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: James Bottomley <James.Bottomley@hansenpartnership.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2016-03-14 8:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 15:47 [PATCH v2 0/3] Introduce device_add_disk() to kill gendisk.driverfs_dev Dan Williams
2016-03-11 15:47 ` [PATCH v2 1/3] block: introduce device_add_disk() Dan Williams
2016-03-14 8:14 ` Johannes Thumshirn
2016-03-11 15:47 ` [PATCH v2 2/3] block: convert to device_add_disk() Dan Williams
2016-03-14 8:15 ` Johannes Thumshirn [this message]
2016-03-11 15:47 ` [PATCH v2 3/3] block: remove ->driverfs_dev Dan Williams
2016-03-14 8:15 ` Johannes Thumshirn
2016-03-11 16:35 ` [PATCH v2 0/3] Introduce device_add_disk() to kill gendisk.driverfs_dev Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314081500.GQ16624@c203.arch.suse.de \
--to=jthumshirn@suse.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=ross.zwisler@linux.intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®