drivers/video/fbdev/aty/atyfb_base.c:3461:2: error: implicit declaration of function 'ioremap_uc'

drivers/video/fbdev/aty/atyfb_base.c:3461:2: error: implicit declaration of function 'ioremap_uc'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1816 bytes --]

Hi Luis,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   67944024c1cdd897e49a09b0d6af3ea38d1388ca
commit: 3cc2dac5be3f23414a4efdee0b26d79bed297cac drivers/video/fbdev/atyfb: Replace MTRR UC hole with strong UC
date:   8 months ago
config: ia64-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 3cc2dac5be3f23414a4efdee0b26d79bed297cac
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   drivers/video/fbdev/aty/atyfb_base.c: In function 'atyfb_setup_generic':
>> drivers/video/fbdev/aty/atyfb_base.c:3461:2: error: implicit declaration of function 'ioremap_uc' [-Werror=implicit-function-declaration]
     par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
     ^
   drivers/video/fbdev/aty/atyfb_base.c:3461:19: warning: assignment makes pointer from integer without a cast
     par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
                      ^
   cc1: some warnings being treated as errors

vim +/ioremap_uc +3461 drivers/video/fbdev/aty/atyfb_base.c

  3455	
  3456		info->fix.mmio_start = raddr;
  3457		/*
  3458		 * By using strong UC we force the MTRR to never have an
  3459		 * effect on the MMIO region on both non-PAT and PAT systems.
  3460		 */
> 3461		par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
  3462		if (par->ati_regbase == NULL)
  3463			return -ENOMEM;
  3464	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 41277 bytes --]

Re: drivers/video/fbdev/aty/atyfb_base.c:3461:2: error: implicit declaration of function 'ioremap_uc'

[Luis R. Rodriguez]

I'll send a fix. I  have it written.

 Luis

On Sun, Mar 06, 2016 at 08:14:07PM +0800, kbuild test robot wrote:
> Hi Luis,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   67944024c1cdd897e49a09b0d6af3ea38d1388ca
> commit: 3cc2dac5be3f23414a4efdee0b26d79bed297cac drivers/video/fbdev/atyfb: Replace MTRR UC hole with strong UC
> date:   8 months ago
> config: ia64-allyesconfig (attached as .config)
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 3cc2dac5be3f23414a4efdee0b26d79bed297cac
>         # save the attached .config to linux build tree
>         make.cross ARCH=ia64 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/video/fbdev/aty/atyfb_base.c: In function 'atyfb_setup_generic':
> >> drivers/video/fbdev/aty/atyfb_base.c:3461:2: error: implicit declaration of function 'ioremap_uc' [-Werror=implicit-function-declaration]
>      par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
>      ^
>    drivers/video/fbdev/aty/atyfb_base.c:3461:19: warning: assignment makes pointer from integer without a cast
>      par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
>                       ^
>    cc1: some warnings being treated as errors
> 
> vim +/ioremap_uc +3461 drivers/video/fbdev/aty/atyfb_base.c
> 
>   3455	
>   3456		info->fix.mmio_start = raddr;
>   3457		/*
>   3458		 * By using strong UC we force the MTRR to never have an
>   3459		 * effect on the MMIO region on both non-PAT and PAT systems.
>   3460		 */
> > 3461		par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
>   3462		if (par->ati_regbase == NULL)
>   3463			return -ENOMEM;
>   3464	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



-- 
Luis Rodriguez, SUSE LINUX GmbH
Maxfeldstrasse 5; D-90409 Nuernberg

[PATCH] ia64: define ioremap_uc()

[Luis R. Rodriguez]

All architectures now need ioremap_uc(), ia64 seems defines
this already through its ioremap_nocache() and it already
ensures it *only* uses UC.

Reported-by: 0 day bot
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---

Note, this is actually needed since v4.3 to complete an allyesconfig
compile on ia64, there were others archs that needed this, and this
one just seems to have fallen through the cracks.

 arch/ia64/include/asm/io.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/ia64/include/asm/io.h b/arch/ia64/include/asm/io.h
index a865d2a04f75..5de673ac9cb1 100644
--- a/arch/ia64/include/asm/io.h
+++ b/arch/ia64/include/asm/io.h
@@ -433,6 +433,7 @@ static inline void __iomem * ioremap_cache (unsigned long phys_addr, unsigned lo
 	return ioremap(phys_addr, size);
 }
 #define ioremap_cache ioremap_cache
+#define ioremap_uc ioremap_nocache
 
 
 /*
-- 
2.7.2

Re: [PATCH] ia64: define ioremap_uc()

[Luis R. Rodriguez]

On Mon, Mar 07, 2016 at 12:34:54PM -0800, Luis R. Rodriguez wrote:
> All architectures now need ioremap_uc(), ia64 seems defines
> this already through its ioremap_nocache() and it already
> ensures it *only* uses UC.
> 
> Reported-by: 0 day bot
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>

*Poke*

  Luis

RE: [PATCH] ia64: define ioremap_uc()

[Luck, Tony]

>> All architectures now need ioremap_uc(), ia64 seems defines
>> this already through its ioremap_nocache() and it already
>> ensures it *only* uses UC.
>> 
>> Reported-by: 0 day bot
>> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
>
> *Poke*

Luis,

Thanks for the reminder.  Applied.

-Tony

Re: [PATCH] ia64: define ioremap_uc()

[Andrew Morton]

On Mon,  7 Mar 2016 12:34:54 -0800 "Luis R. Rodriguez" <mcgrof@kernel.org> wrote:

> All architectures now need ioremap_uc(), ia64 seems defines
> this already through its ioremap_nocache() and it already
> ensures it *only* uses UC.
> 
> Reported-by: 0 day bot
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> ---
> 
> Note, this is actually needed since v4.3 to complete an allyesconfig
> compile on ia64, there were others archs that needed this, and this
> one just seems to have fallen through the cracks.

So a cc:stable was needed.  I've added that to my copy of the patch. 
Tony ack?

RE: [PATCH] ia64: define ioremap_uc()

[Luck, Tony]

>> Note, this is actually needed since v4.3 to complete an allyesconfig
>> compile on ia64, there were others archs that needed this, and this
>> one just seems to have fallen through the cracks.
>
> So a cc:stable was needed.  I've added that to my copy of the patch. 
> Tony ack?

Acked-by: Tony Luck <tony.luck@intel.com>