From: Andi Kleen <ak@linux.intel.com>
To: Dave Jones <davej@codemonkey.org.uk>,
x86@kernel.org, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fix suspicious RCU usage in msr tracing.
Date: Tue, 15 Mar 2016 09:39:56 -0700 [thread overview]
Message-ID: <20160315163956.GQ23621@tassilo.jf.intel.com> (raw)
In-Reply-To: <20160315012054.GA17765@codemonkey.org.uk>
> Back in January, Andi suggested swapping the order in which
> we ack the APIC irq, so it too is protected by rcu.
> There was no follow-up, and it seems to work for me.
>
> Cc: Andi Kleen <ak@linux.intel.com>
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
>
> diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
> index c80f6b6f3da2..e8c4fba52d3d 100644
> --- a/arch/x86/include/asm/apic.h
> +++ b/arch/x86/include/asm/apic.h
> @@ -644,8 +644,8 @@ static inline void entering_irq(void)
>
> static inline void entering_ack_irq(void)
> {
> - ack_APIC_irq();
> entering_irq();
> + ack_APIC_irq();
> }
>
> static inline void ipi_entering_ack_irq(void)
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2016-03-15 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 1:20 Dave Jones
2016-03-15 16:39 ` Andi Kleen [this message]
2016-03-18 13:54 ` [tip:x86/urgent] x86/apic: Fix suspicious RCU usage in smp_trace_call_function_interrupt() tip-bot for Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315163956.GQ23621@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome