mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Gavin O'Leary" <gavinoleary3@gmail.com>
Cc: david.kershner@unisys.com, benjamin.romer@unisys.com,
	timothy.sell@unisys.com, nhorman@redhat.com,
	sparmaintainer@unisys.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: unisys: visornic: Fixed Checkpatch Warnings
Date: Wed, 16 Mar 2016 18:35:13 -0700	[thread overview]
Message-ID: <20160317013513.GA14065@kroah.com> (raw)
In-Reply-To: <1458177887-4779-1-git-send-email-gavinoleary3@gmail.com>

On Wed, Mar 16, 2016 at 06:24:47PM -0700, Gavin O'Leary wrote:
> Fixed the coding style checkpatch warnings.

Which ones?  Always be specific.  And only fix one type of thing at a
time.

> 
> Signed-off-by: Gavin O'Leary <gavinoleary3@gmail.com>
> ---
>  drivers/staging/unisys/visornic/visornic_main.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
> index 0519470..0366624 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -1218,8 +1218,9 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
>  		/* length rcvd is greater than firstfrag in this skb rcv buf  */
>  		skb->tail += RCVPOST_BUF_SIZE;	/* amount in skb->data */
>  		skb->data_len = skb->len - RCVPOST_BUF_SIZE;	/* amount that
> -								   will be in
> -								   frag_list */
> +								 *  will be in
> +								 *  frag_list
> +								 */

Tell me that looks better :(

Please fix this properly.

thanks,

greg k-h

      reply	other threads:[~2016-03-17  1:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17  1:24 Gavin O'Leary
2016-03-17  1:35 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160317013513.GA14065@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=benjamin.romer@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gavinoleary3@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sparmaintainer@unisys.com \
    --cc=timothy.sell@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®