From: Peter Zijlstra <peterz@infradead.org>
To: kan.liang@intel.com
Cc: tglx@linutronix.de, ak@linux.intel.com, eranian@google.com,
mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular
Date: Fri, 18 Mar 2016 09:32:36 +0100 [thread overview]
Message-ID: <20160318083236.GE6344@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1458218055-25920-1-git-send-email-kan.liang@intel.com>
On Thu, Mar 17, 2016 at 05:34:14AM -0700, kan.liang@intel.com wrote:
> +static void __exit intel_uncore_exit(void)
> +{
> + cpu_notifier_register_done();
Did you even test this? That should be _begin();
> + __unregister_cpu_notifier(&uncore_cpu_nb);
> + uncore_types_exit(uncore_msr_uncores);
> + uncore_pci_exit();
> + cpu_notifier_register_done();
> +}
> +module_exit(intel_uncore_exit);
> --
> 2.5.0
>
next prev parent reply other threads:[~2016-03-18 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 12:34 kan.liang
2016-03-17 12:34 ` [PATCH 2/2] x86/perf/intel/uncore: Make Intel rapl modular kan.liang
2016-03-18 8:32 ` Peter Zijlstra [this message]
2016-03-18 8:45 ` [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318083236.GE6344@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®