From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kan.liang@intel.com, ak@linux.intel.com, eranian@google.com,
mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular
Date: Fri, 18 Mar 2016 09:45:30 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1603180944320.3978@nanos> (raw)
In-Reply-To: <20160318083236.GE6344@twins.programming.kicks-ass.net>
On Fri, 18 Mar 2016, Peter Zijlstra wrote:
> On Thu, Mar 17, 2016 at 05:34:14AM -0700, kan.liang@intel.com wrote:
> > +static void __exit intel_uncore_exit(void)
> > +{
> > + cpu_notifier_register_done();
>
> Did you even test this? That should be _begin();
That's my fault. I had this in my proof of concept patch and it actually works
for some reason. By some definition of works: i.e. it does not explode in your
face right away....
prev parent reply other threads:[~2016-03-18 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 12:34 kan.liang
2016-03-17 12:34 ` [PATCH 2/2] x86/perf/intel/uncore: Make Intel rapl modular kan.liang
2016-03-18 8:32 ` [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular Peter Zijlstra
2016-03-18 8:45 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1603180944320.3978@nanos \
--to=tglx@linutronix.de \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®