mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] regulator: Lookup unresolved parent supplies before regulators cleanup
Date: Mon, 21 Mar 2016 11:11:00 +0000	[thread overview]
Message-ID: <20160321111100.GN2566@sirena.org.uk> (raw)
In-Reply-To: <1458527986-4576-1-git-send-email-javier@osg.samsung.com>

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

On Sun, Mar 20, 2016 at 11:39:46PM -0300, Javier Martinez Canillas wrote:

> Unfortunately, that changed the behavior of the regulator core since now a
> parent supply with a child regulator marked as always-on, won't be enabled
> unless a client driver attempts to get the child regulator during boot.

> This patch makes the unresolved parent supplies to be looked up before the
> regulators late cleanup, so those with a child marked as always on will be
> enabled regardless if a driver attempted to get the child regulator or not.

This doesn't make much sense to me as a fix - it feels like we're doing
a fragile hack.  Surely it's better to do this as we register the
devices, that way we're also protected against any similar issues with
this that might occur after late probe if things are built modular?  Or
is there a strong reason for doing this only at late_initcall?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-03-21 11:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21  2:39 Javier Martinez Canillas
2016-03-21 11:11 ` Mark Brown [this message]
2016-03-21 12:13   ` Javier Martinez Canillas
2016-03-21 12:25     ` Javier Martinez Canillas
2016-03-21 12:37     ` Mark Brown
2016-03-21 12:44       ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160321111100.GN2566@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=javier@osg.samsung.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®