From: Mark Brown <broonie@kernel.org>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: regmap: mmio: regression in pre-v4.6-rc1
Date: Wed, 23 Mar 2016 12:05:35 +0000 [thread overview]
Message-ID: <20160323120535.GK2566@sirena.org.uk> (raw)
In-Reply-To: <2546687.zGbvS8bYIW@ws-stein>
[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]
On Wed, Mar 23, 2016 at 12:50:53PM +0100, Alexander Stein wrote:
As I said previously please fix your mail client to word wrap within
paragraphs at something substantially less than 80 columns. Doing this
makes your messages much easier to read and reply to.
> > > In regmap_mmio_gen_context ctx->reg_read is set to regmap_mmio_read32le and
> > > ctx->reg_write to regmap_mmio_write32le respectively.
> > So how does that happen then? We set these values if the bus is
> > default, little or native endian but if it's big endian we go into a
> > completely different case...
> Well, in regmap_mmio_gen_context config->reg_format_endian is still
> set to REGMAP_ENDIAN_DEFAULT. of_syscon_register sets
> config.val_format_endian (notice val_ instead of reg_) depending on
> "big-endian" (or "little-endian") property. I'm kinda confused
> regarding reg_format_endian and val_format_endian. Dunno what should
> be set in which way.
Ah, I see. That's definitely broken - if we're changing the value
format we should be checking the value.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-03-23 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 8:48 Alexander Stein
2016-03-23 9:43 ` Alexander Stein
2016-03-23 10:34 ` Mark Brown
2016-03-23 11:16 ` Alexander Stein
2016-03-23 11:39 ` Mark Brown
2016-03-23 11:50 ` Alexander Stein
2016-03-23 12:05 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323120535.GK2566@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexander.stein@systec-electronic.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®