From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jeffrey Merkey <jeffmerkey@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>, Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: [GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64
Date: Sat, 26 Mar 2016 12:48:44 +1100 [thread overview]
Message-ID: <20160326124844.417c23a5@canb.auug.org.au> (raw)
In-Reply-To: <CA+ekxPVrWrz6UOkBDtNxZ1KAO7A95=88z8ZE=mt8AKui0CU5mQ@mail.gmail.com>
Hi Jeff,
On Fri, 25 Mar 2016 17:01:27 -0600 Jeffrey Merkey <jeffmerkey@gmail.com> wrote:
>
> I went back and checked the code and as it turns out, none of the
> patches you nak'd are in the current branch, there are different
> patches there now. There are two patches you ignored that are in it,
> but no record of a Nak for either of them.
OK, so one obvious problem is that the tree you want merged has a
single patch in it and the diffstat looks like this:
Documentation/sysrq.txt | 2 +-
MAINTAINERS | 6 +
arch/x86/include/asm/bug.h | 9 +-
arch/x86/include/uapi/asm/debugreg.h | 1 +
arch/x86/kernel/Makefile | 1 +
arch/x86/kernel/apic/io_apic.c | 2 +
arch/x86/kernel/debug/Makefile | 3 +
arch/x86/kernel/debug/mdb/Makefile | 6 +
arch/x86/kernel/debug/mdb/Makefile.local | 106 +
arch/x86/kernel/debug/mdb/mdb-base.c | 3293 +++++++++++++
arch/x86/kernel/debug/mdb/mdb-base.h | 447 ++
arch/x86/kernel/debug/mdb/mdb-ia-apic.c | 243 +
arch/x86/kernel/debug/mdb/mdb-ia-proc.h | 819 ++++
arch/x86/kernel/debug/mdb/mdb-ia-support.c | 5342 +++++++++++++++++++++
arch/x86/kernel/debug/mdb/mdb-ia-support.h | 76 +
arch/x86/kernel/debug/mdb/mdb-ia.c | 6887 ++++++++++++++++++++++++++++
arch/x86/kernel/debug/mdb/mdb-ia.h | 209 +
arch/x86/kernel/debug/mdb/mdb-keyboard.h | 127 +
arch/x86/kernel/debug/mdb/mdb-list.c | 534 +++
arch/x86/kernel/debug/mdb/mdb-list.h | 96 +
arch/x86/kernel/debug/mdb/mdb-logic.c | 2118 +++++++++
arch/x86/kernel/debug/mdb/mdb-main.c | 786 ++++
arch/x86/kernel/debug/mdb/mdb-os.c | 1474 ++++++
arch/x86/kernel/debug/mdb/mdb-os.h | 141 +
arch/x86/kernel/debug/mdb/mdb-proc.h | 179 +
arch/x86/kernel/debug/mdb/mdb.h | 40 +
arch/x86/kernel/dumpstack_32.c | 6 +-
arch/x86/kernel/dumpstack_64.c | 18 +
arch/x86/kernel/hw_breakpoint.c | 69 +-
arch/x86/kernel/reboot.c | 1 +
arch/x86/kernel/traps.c | 14 +
drivers/tty/vt/vt.c | 4 +
include/asm-generic/bug.h | 4 +
include/linux/console.h | 4 +
kernel/debug/kdb/kdb_debugger.c | 2 +-
kernel/events/hw_breakpoint.c | 2 +
kernel/extable.c | 1 +
kernel/kallsyms.c | 45 +
kernel/module.c | 43 +
kernel/rcu/tree.c | 1 +
kernel/sched/core.c | 13 +-
kernel/time/clocksource.c | 1 +
kernel/watchdog.c | 17 +-
lib/Kconfig.debug | 66 +
44 files changed, 23240 insertions(+), 18 deletions(-)
Having it in that form makes it pretty hard for anyone to review ...
If you have a set if incremental patches, maybe you should post those
instead.
I am afraid that if the maintainers affected by this code will not
merge it, I cannot justify putting it in linux-next myself.
--
Cheers,
Stephen Rothwell
next prev parent reply other threads:[~2016-03-26 1:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 23:50 Jeffrey Merkey
2016-03-14 23:57 ` Joe Perches
2016-03-15 0:24 ` Stephen Rothwell
2016-03-15 0:40 ` Jeffrey Merkey
2016-03-15 2:03 ` Stephen Rothwell
2016-03-15 15:16 ` Theodore Ts'o
2016-03-16 23:27 ` Jeffrey Merkey
2016-03-18 5:31 ` Jeffrey Merkey
2016-03-18 5:40 ` Joe Perches
2016-03-18 5:43 ` Jeffrey Merkey
2016-03-25 8:36 ` Ingo Molnar
2016-03-25 17:17 ` Jeffrey Merkey
2016-03-25 17:27 ` Jeffrey Merkey
2016-03-25 23:01 ` Jeffrey Merkey
2016-03-25 23:02 ` Jeffrey Merkey
2016-03-26 1:48 ` Stephen Rothwell [this message]
2016-03-26 1:56 ` Jeffrey Merkey
2016-03-26 1:48 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160326124844.417c23a5@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=jeffmerkey@gmail.com \
--cc=joe@perches.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®