From: Steven Rostedt <rostedt@goodmis.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Josh Cartwright <joshc@ni.com>, Daniel Wagner <wagi@monom.org>,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Daniel Wagner <daniel.wagner@bmw-carit.de>
Subject: Re: [RFC v0] Use swait in completion
Date: Mon, 28 Mar 2016 14:57:02 -0400 [thread overview]
Message-ID: <20160328145702.589da4bd@gandalf.local.home> (raw)
In-Reply-To: <20160309122423.GD10517@linutronix.de>
On Wed, 9 Mar 2016 13:24:23 +0100
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> * Josh Cartwright | 2016-03-08 12:26:56 [-0600]:
>
> >Is it really just about latency? Does this deferral not lead to an
> >inversion in the case where the single woken task isn't the highest
> >priority waiter on the completion (and doesn't run due to a
> >middle-priority thing spinning)?
>
> This would be case, yes. Not only with deferral. Say you have two
> waters: 1st one is MID-prio and the second is HI-prio. Currently after
> the wakeup of the MID-prio waiter you get preempted. Waking all of them
> at once would put the second waiter first on the CPU.
> Samething without the deferral flag.
>
> >In order for this to work, it seems like the chosen waiter would need to
> >inherit the highest priority of all waiters (which AFAICT isn't
> >happening).
>
> sorting the waiters by priority? This will be fun. This is only done for
> the rtmutex waiters.
>
Hmm, perhaps we should use an rbtree to sort simple waiters by
priority :-)
Probably wont make them simple anymore.
-- Steve
next prev parent reply other threads:[~2016-03-28 18:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 15:59 Daniel Wagner
2016-03-08 15:59 ` [RFC v0] sched/completion: convert completions to use simple wait queues Daniel Wagner
2016-03-08 17:52 ` [RFC v0] Use swait in completion Sebastian Andrzej Siewior
2016-03-08 18:07 ` Daniel Wagner
2016-03-08 18:26 ` Josh Cartwright
2016-03-09 12:24 ` Sebastian Andrzej Siewior
2016-03-28 18:57 ` Steven Rostedt [this message]
2016-03-31 6:14 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328145702.589da4bd@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=daniel.wagner@bmw-carit.de \
--cc=joshc@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®